Bug 125381 - CStack Branch: Fix Specialized Thunks to use function prologues and epilogues
Summary: CStack Branch: Fix Specialized Thunks to use function prologues and epilogues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-06 22:26 PST by Michael Saboff
Modified: 2014-01-13 18:46 PST (History)
9 users (show)

See Also:

Attachments
Patch (3.34 KB, patch)
2013-12-06 22:29 PST, Michael Saboff 		ggaren: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-12-06 22:26:30 PST 
The SpecializedThunkJIT generator isn't using the function prologue / epilogue for the native convention.
Comment 1 Michael Saboff 2013-12-06 22:29:53 PST 
Created attachment 218651 [details]
Patch

With this change, the LLInt can run v8-crypto.js to completion.
Comment 2 EFL EWS Bot 2013-12-06 22:33:17 PST 
Comment on attachment 218651 [details]
Patch

Attachment 218651 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/46408019
Comment 3 EFL EWS Bot 2013-12-06 22:34:34 PST 
Comment on attachment 218651 [details]
Patch

Attachment 218651 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/46428014
Comment 4 kov's GTK+ EWS bot 2013-12-06 22:37:51 PST 
Comment on attachment 218651 [details]
Patch

Attachment 218651 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/46468014
Comment 5 Michael Saboff 2013-12-06 22:39:31 PST 
Patch landed in change set r160268  <http://trac.webkit.org/changeset/160268>.
Comment 6 Build Bot 2013-12-06 23:00:45 PST 
Comment on attachment 218651 [details]
Patch

Attachment 218651 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/46468015
Comment 7 Build Bot 2013-12-06 23:09:58 PST 
Comment on attachment 218651 [details]
Patch

Attachment 218651 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/46418014
Comment 8 Build Bot 2013-12-06 23:28:05 PST 
Comment on attachment 218651 [details]
Patch

Attachment 218651 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/46468016
Comment 9 Geoffrey Garen 2013-12-07 10:51:27 PST 
Comment on attachment 218651 [details]
Patch

r=me
Comment 10 Geoffrey Garen 2013-12-07 10:51:41 PST 
> With this change, the LLInt can run v8-crypto.js to completion.

Nice!
Comment 11 Mark Lam 2014-01-13 18:46:20 PST 
Review status updated in r161938: <http://trac.webkit.org/r161938>.