WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125381
CStack Branch: Fix Specialized Thunks to use function prologues and epilogues
https://bugs.webkit.org/show_bug.cgi?id=125381
Summary
CStack Branch: Fix Specialized Thunks to use function prologues and epilogues
Michael Saboff
Reported
2013-12-06 22:26:30 PST
The SpecializedThunkJIT generator isn't using the function prologue / epilogue for the native convention.
Attachments
Patch
(3.34 KB, patch)
2013-12-06 22:29 PST
,
Michael Saboff
ggaren
: review+
eflews.bot
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Saboff
Comment 1
2013-12-06 22:29:53 PST
Created
attachment 218651
[details]
Patch With this change, the LLInt can run v8-crypto.js to completion.
EFL EWS Bot
Comment 2
2013-12-06 22:33:17 PST
Comment on
attachment 218651
[details]
Patch
Attachment 218651
[details]
did not pass efl-ews (efl): Output:
http://webkit-queues.appspot.com/results/46408019
EFL EWS Bot
Comment 3
2013-12-06 22:34:34 PST
Comment on
attachment 218651
[details]
Patch
Attachment 218651
[details]
did not pass efl-wk2-ews (efl-wk2): Output:
http://webkit-queues.appspot.com/results/46428014
kov's GTK+ EWS bot
Comment 4
2013-12-06 22:37:51 PST
Comment on
attachment 218651
[details]
Patch
Attachment 218651
[details]
did not pass gtk-ews (gtk): Output:
http://webkit-queues.appspot.com/results/46468014
Michael Saboff
Comment 5
2013-12-06 22:39:31 PST
Patch landed in change set
r160268
<
http://trac.webkit.org/changeset/160268
>.
Build Bot
Comment 6
2013-12-06 23:00:45 PST
Comment on
attachment 218651
[details]
Patch
Attachment 218651
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/46468015
Build Bot
Comment 7
2013-12-06 23:09:58 PST
Comment on
attachment 218651
[details]
Patch
Attachment 218651
[details]
did not pass win-ews (win): Output:
http://webkit-queues.appspot.com/results/46418014
Build Bot
Comment 8
2013-12-06 23:28:05 PST
Comment on
attachment 218651
[details]
Patch
Attachment 218651
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/46468016
Geoffrey Garen
Comment 9
2013-12-07 10:51:27 PST
Comment on
attachment 218651
[details]
Patch r=me
Geoffrey Garen
Comment 10
2013-12-07 10:51:41 PST
> With this change, the LLInt can run v8-crypto.js to completion.
Nice!
Mark Lam
Comment 11
2014-01-13 18:46:20 PST
Review status updated in
r161938
: <
http://trac.webkit.org/r161938
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug