WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
125374
check-webkit-style shouldn't check indent of #define directives within initializer lists
https://bugs.webkit.org/show_bug.cgi?id=125374
Summary
check-webkit-style shouldn't check indent of #define directives within initia...
Brian Burg
Reported
2013-12-06 17:39:45 PST
Test case where it spuriously complains about indentation: RenderFileUploadControl::RenderFileUploadControl(HTMLInputElement& input, PassRef<RenderStyle> style) : RenderBlockFlow(input, std::move(style)) #if ENABLE(DRAG_SUPPORT) , m_canReceiveDroppedFiles(input.canReceiveDroppedFiles()) #endif { }
Attachments
Add attachment
proposed patch, testcase, etc.
Brian Burg
Comment 1
2013-12-08 12:29:34 PST
It appears I was using an old version of the style checker, as I can't reproduce on my other machine and the relevant test cases in cpp_unittest.py seem to pass.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug