Bug 125364 – check-webkit-style should understand --git-index

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Brian Burg]

prepare-Changelog can figure out how to only consider things in the git index (i.e., git diff --cached). check-webkit-style should support this option as well. It is useful for splitting changes into smaller patches.

I think this was also suggested here, in the context of bigger changes: https://bugs.webkit.org/show_bug.cgi?id=35781

[Berta József]

Created attachment 229974 [details]
Adding --git-index option

[WebKit Commit Bot]

Comment on attachment 229974 [details]
Adding --git-index option

Clearing flags on attachment: 229974

Committed r167926: <http://trac.webkit.org/changeset/167926>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Mark Lam]

This patch broke the Tools/Scripts/check-webkit-style script when run on a svn checkout.  For example:

$ ./Tools/Scripts/check-webkit-style 
Traceback (most recent call last):
  File "./Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "/OpenSource/Tools/Scripts/webkitpy/style/main.py", line 152, in main
    patch = host.scm().create_patch(options.git_commit, changed_files=changed_files, git_index=options.git_index)
TypeError: create_patch() got an unexpected keyword argument 'git_index'

[Lucas Forschler]

I think this can be fixed by adding a simple git_index=None argument to the create_patch function in checkout/scm/svn.py

[Lucas Forschler]

Follow-up in 167957.