Bug 125357 - Strip out extraneous logging from AppleGVA in media tests.
Summary: Strip out extraneous logging from AppleGVA in media tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
: 125356 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-06 11:40 PST by Jer Noble
Modified: 2014-07-17 10:29 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.32 KB, patch)
2013-12-06 11:44 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (7.26 KB, patch)
2013-12-06 13:22 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (7.33 KB, patch)
2013-12-06 13:23 PST, Jer Noble 		simon.fraser: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-12-06 11:40:16 PST 
Strip out extraneous logging from AppleGVA in media tests.
Comment 1 Jer Noble 2013-12-06 11:44:57 PST 
Created attachment 218608 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-12-06 11:48:10 PST 
Comment on attachment 218608 [details]
Patch

Cool. Please also roll out r160233 with this.
Comment 3 Simon Fraser (smfr) 2013-12-06 11:52:29 PST 
Comment on attachment 218608 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218608&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:294
> +        test_input.is_media_test = self._port.is_media_test(test_input)

I don't think this logging filtering needs to be restricted to media tests.

> Tools/Scripts/webkitpy/port/driver.py:81
> +    strip_media_logging_patterns.append((re.compile('AVF info:.*\n'), ''))
> +    strip_media_logging_patterns.append((re.compile('GVA info:.*\n'), ''))

You could fold these two regexps together.

I think these regexps should go into a platform-specific python file, since it's platform logging that you're filtering.
Comment 4 Jer Noble 2013-12-06 13:22:41 PST 
Created attachment 218616 [details]
Patch
Comment 5 Jer Noble 2013-12-06 13:23:58 PST 
Created attachment 218617 [details]
Patch

Added a FIXME, as suggested by bdash over IRC.
Comment 6 Build Bot 2013-12-06 14:07:16 PST 
Comment on attachment 218617 [details]
Patch

Attachment 218617 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/45808111
Comment 7 Jer Noble 2013-12-06 14:19:28 PST 
Committed r160247: <http://trac.webkit.org/changeset/160247>
Comment 8 Alexey Proskuryakov 2014-07-17 10:29:25 PDT 
*** Bug 125356 has been marked as a duplicate of this bug. ***