Bug 125351 - Clean up the includes of RenderBlock.h
Summary: Clean up the includes of RenderBlock.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-06 09:39 PST by Zoltan Horvath
Modified: 2013-12-06 11:29 PST (History)
1 user (show)

See Also:

Attachments
Patch (5.66 KB, patch)
2013-12-06 09:49 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Patch - updated changelog (5.66 KB, patch)
2013-12-06 09:55 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Patch - updated changelog (5.67 KB, patch)
2013-12-06 10:31 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-12-06 09:39:24 PST 
I changed some headers to forward declaration, and I removed/moved out some includes, which don't really belong to RenderBlock.h anymore.
Comment 1 Zoltan Horvath 2013-12-06 09:49:06 PST 
Created attachment 218601 [details]
Patch
Comment 2 Zoltan Horvath 2013-12-06 09:55:47 PST 
Created attachment 218602 [details]
Patch - updated changelog
Comment 3 Zoltan Horvath 2013-12-06 10:31:49 PST 
Created attachment 218605 [details]
Patch - updated changelog
Comment 4 Darin Adler 2013-12-06 10:41:39 PST 
Comment on attachment 218605 [details]
Patch - updated changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=218605&action=review

One small comment, but I’m going to do commit-queue+ anyway.

> Source/WebCore/rendering/RenderBlock.h:42
> +#if ENABLE(CSS_SHAPES)
> +class ShapeInsideInfo;
> +class ShapeValue;
> +#endif

I’m not sure we need to put forward declarations into #if statements. There is a small benefit (compile error if we use them by accident), but it looks ugly and the benefit is really small.

If we do keep the #if then better to add a blank line so it can be a separate “code paragraph”.
Comment 5 WebKit Commit Bot 2013-12-06 11:29:00 PST 
Comment on attachment 218605 [details]
Patch - updated changelog

Clearing flags on attachment: 218605

Committed r160235: <http://trac.webkit.org/changeset/160235>
Comment 6 WebKit Commit Bot 2013-12-06 11:29:02 PST 
All reviewed patches have been landed.  Closing bug.