RESOLVED FIXED 125341
Remove function from style/checkers/cpp.py 
https://bugs.webkit.org/show_bug.cgi?id=125341
Summary Remove function from style/checkers/cpp.py
Tamas Gergely
Reported 2013-12-06 01:26:31 PST
There is a FIXME: to remove process_file_data from style/checkers/cpp.py.
Attachments
patch removes a function (3.38 KB, patch)
2013-12-06 01:55 PST, Tamas Gergely 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tamas Gergely
Comment 1 2013-12-06 01:55:10 PST
Created attachment 218579 [details] patch removes a function I have simply split the functionality of process_file_data into two parts: the checker is now created directly in the CppStyleTestBase unit test, while setting the module's global _unit_test_config is done from the constructor of CppChecker. Although currently it causes no problem, I think that setting the global from the constructor is not a nice nor safe solution. What could be done are: - move the global into the CppChecker class and propagate its value (through 3 functions) to the only place it is used (the 3 functions are used nowhere else), or - move all the functions (or almost all) into the CppChecker class, or - leave it as it is now. By the way, to set up some specific environments, the cpp_unittest uses both globals and parameter propagation. Is one of them preferred?
WebKit Commit Bot
Comment 2 2013-12-06 10:54:45 PST
Comment on attachment 218579 [details] patch removes a function Clearing flags on attachment: 218579 Committed r160230: <http://trac.webkit.org/changeset/160230>
WebKit Commit Bot
Comment 3 2013-12-06 10:57:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.