RESOLVED DUPLICATE of bug 105280 125340
PageConsole::addMessage does not set position in every cases. 
https://bugs.webkit.org/show_bug.cgi?id=125340
Summary PageConsole::addMessage does not set position in every cases.
László Langó
Reported 2013-12-06 01:05:23 PST
WebCore/page/PageConsole.cpp: FIXME: The below code attempts to determine line numbers for parser generated errors, but this is not the only reason why we can get here. For example, if we are still parsing and get a WebSocket network error, it will be erroneously attributed to a line where parsing was paused. Also, we should determine line numbers for script generated messages (e.g. calling getImageData on a canvas). We probably need to split this function into multiple ones, as appropriate for different call sites. Or maybe decide based on MessageSource.
Attachments
Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-01-16 16:48:36 PST
> Also, we should determine line numbers for script generated messages (e.g. calling getImageData on a canvas). This works now, as we reuse ConsoleMessage's processing to get the code location. > For example, if we are still parsing and get a WebSocket network error, it will be erroneously attributed to a line where parsing was paused. This is bug 105280. *** This bug has been marked as a duplicate of bug 105280 ***
Note You need to log in before you can comment on or make changes to this bug.