Bug 125336 - [MSE] Add a runtime-setting for the MediaSource constructor.
Summary: [MSE] Add a runtime-setting for the MediaSource constructor.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-05 23:28 PST by Jer Noble
Modified: 2013-12-06 16:53 PST (History)
12 users (show)

See Also:

Attachments
Patch (10.05 KB, patch)
2013-12-05 23:30 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (627.31 KB, application/zip)
2013-12-06 02:37 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (576.45 KB, application/zip)
2013-12-06 03:48 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (613.98 KB, application/zip)
2013-12-06 04:05 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (622.34 KB, application/zip)
2013-12-06 04:24 PST, Build Bot 		no flags Details
Patch (10.66 KB, patch)
2013-12-06 08:53 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (12.14 KB, patch)
2013-12-06 09:10 PST, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-12-05 23:28:03 PST 
[MSE] Add a runtime-setting for the MediaSource constructor.
Comment 1 Jer Noble 2013-12-05 23:30:57 PST 
Created attachment 218573 [details]
Patch
Comment 2 Build Bot 2013-12-06 02:37:47 PST 
Comment on attachment 218573 [details]
Patch

Attachment 218573 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/45308036

New failing tests:
js/dom/global-constructors-attributes.html
js/dom/JSON-parse.html
media/media-source/media-source-append-buffer.html
media/media-source/media-source-closed.html
media/media-source/media-source-fastseek.html
media/media-source/media-source-canplaythrough.html
media/media-source/media-source-tracks.html
media/media-source/media-source-append-failed.html
media/media-source/media-source-track-enabled.html
media/media-source/media-source-addsourcebuffer.html
media/media-source/media-source-play.html
Comment 3 Build Bot 2013-12-06 02:37:49 PST 
Created attachment 218583 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2013-12-06 03:48:38 PST 
Comment on attachment 218573 [details]
Patch

Attachment 218573 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/45408006

New failing tests:
js/dom/global-constructors-attributes.html
media/media-source/media-source-append-buffer.html
media/media-source/media-source-closed.html
media/media-source/media-source-fastseek.html
media/media-source/media-source-canplaythrough.html
media/media-source/media-source-tracks.html
media/media-source/media-source-append-failed.html
media/media-source/media-source-track-enabled.html
media/media-source/media-source-addsourcebuffer.html
media/media-source/media-source-play.html
Comment 5 Build Bot 2013-12-06 03:48:40 PST 
Created attachment 218587 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2013-12-06 04:05:14 PST 
Comment on attachment 218573 [details]
Patch

Attachment 218573 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/45098033

New failing tests:
js/dom/global-constructors-attributes.html
js/dom/JSON-parse.html
media/media-source/media-source-append-buffer.html
media/media-source/media-source-closed.html
media/media-source/media-source-fastseek.html
media/media-source/media-source-canplaythrough.html
media/media-source/media-source-tracks.html
media/media-source/media-source-append-failed.html
media/media-source/media-source-track-enabled.html
media/media-source/media-source-addsourcebuffer.html
media/media-source/media-source-play.html
Comment 7 Build Bot 2013-12-06 04:05:16 PST 
Created attachment 218588 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 8 Build Bot 2013-12-06 04:24:54 PST 
Comment on attachment 218573 [details]
Patch

Attachment 218573 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/44638040

New failing tests:
js/dom/global-constructors-attributes.html
js/dom/JSON-parse.html
media/media-source/media-source-append-buffer.html
media/media-source/media-source-closed.html
media/media-source/media-source-fastseek.html
media/media-source/media-source-canplaythrough.html
media/media-source/media-source-tracks.html
media/media-source/media-source-append-failed.html
media/media-source/media-source-track-enabled.html
media/media-source/media-source-addsourcebuffer.html
media/media-source/media-source-play.html
Comment 9 Build Bot 2013-12-06 04:24:56 PST 
Created attachment 218590 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 Jer Noble 2013-12-06 08:53:22 PST 
Created attachment 218598 [details]
Patch

Enable the MSE setting when installing the mock media engine.
Comment 11 kov's GTK+ EWS bot 2013-12-06 09:00:28 PST 
Comment on attachment 218598 [details]
Patch

Attachment 218598 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/45838043
Comment 12 Jer Noble 2013-12-06 09:10:22 PST 
Created attachment 218600 [details]
Patch

A different approach: Enable MediaSource in DRT and WKTR by default.
Comment 13 Darin Adler 2013-12-06 10:24:17 PST 
(In reply to comment #0)
> [MSE] Add a runtime-setting for the MediaSource constructor.

Rationale?
Comment 14 Jer Noble 2013-12-06 10:50:56 PST 
(In reply to comment #13)
> (In reply to comment #0)
> > [MSE] Add a runtime-setting for the MediaSource constructor.
> 
> Rationale?

YouTube will preferentially use MSE if the MediaSource API is present.  Disabling it at runtime allows us to bring up MSE without breaking YouTube.

This came up because of: <rdar://problem/15587450>.
Comment 15 Eric Carlson 2013-12-06 11:41:29 PST 
Comment on attachment 218600 [details]
Patch

Looks good to me (or should I say LGTM) but you may want to check with Darin.
Comment 16 Jer Noble 2013-12-06 16:21:32 PST 
(In reply to comment #15)
> (From update of attachment 218600 [details])
> Looks good to me (or should I say LGTM) but you may want to check with Darin.

Given that it fixes a pretty big bug with YouTube, I'll check it in now, and roll-out if Darin objects. :)
Comment 17 Jer Noble 2013-12-06 16:53:42 PST 
Committed r160261: <http://trac.webkit.org/changeset/160261>