WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125327
Remove Image::decodedSize()
https://bugs.webkit.org/show_bug.cgi?id=125327
Summary
Remove Image::decodedSize()
Tim Horton
Reported
2013-12-05 17:40:27 PST
It's not used... at all. Decoded size is tracked on CachedResource via decodedSizeChanged(); nothing ever calls these. Threw me off a good bit recently.
Attachments
patch
(5.90 KB, patch)
2013-12-05 17:42 PST
,
Tim Horton
no flags
Details
Formatted Diff
Diff
remove comment I missed
(1.12 KB, patch)
2013-12-06 13:31 PST
,
Tim Horton
no flags
Details
Formatted Diff
Diff
leave part that's still true
(1.21 KB, patch)
2013-12-06 13:32 PST
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2013-12-05 17:42:18 PST
Created
attachment 218561
[details]
patch
WebKit Commit Bot
Comment 2
2013-12-05 18:49:23 PST
Comment on
attachment 218561
[details]
patch Clearing flags on attachment: 218561 Committed
r160207
: <
http://trac.webkit.org/changeset/160207
>
WebKit Commit Bot
Comment 3
2013-12-05 18:49:26 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4
2013-12-06 09:24:24 PST
Comment on
attachment 218561
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=218561&action=review
> Source/WebCore/svg/graphics/SVGImage.h:86 > // FIXME: SVGImages are underreporting decoded sizes and will be unable > // to prune because these functions are not implemented yet.
This comment seems obsolete as well.
Tim Horton
Comment 5
2013-12-06 13:30:59 PST
Yes!
Tim Horton
Comment 6
2013-12-06 13:31:22 PST
Created
attachment 218618
[details]
remove comment I missed
Tim Horton
Comment 7
2013-12-06 13:32:48 PST
Created
attachment 218620
[details]
leave part that's still true
WebKit Commit Bot
Comment 8
2013-12-06 14:24:31 PST
Comment on
attachment 218620
[details]
leave part that's still true Clearing flags on attachment: 218620 Committed
r160248
: <
http://trac.webkit.org/changeset/160248
>
WebKit Commit Bot
Comment 9
2013-12-06 14:24:34 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug