Bug 125327 - Remove Image::decodedSize()
Summary: Remove Image::decodedSize()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-05 17:40 PST by Tim Horton
Modified: 2013-12-06 14:24 PST (History)
9 users (show)

See Also:


Attachments
patch (5.90 KB, patch)
2013-12-05 17:42 PST, Tim Horton
no flags Details | Formatted Diff | Diff
remove comment I missed (1.12 KB, patch)
2013-12-06 13:31 PST, Tim Horton
no flags Details | Formatted Diff | Diff
leave part that's still true (1.21 KB, patch)
2013-12-06 13:32 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-12-05 17:40:27 PST
It's not used... at all. Decoded size is tracked on CachedResource via decodedSizeChanged(); nothing ever calls these. Threw me off a good bit recently.
Comment 1 Tim Horton 2013-12-05 17:42:18 PST
Created attachment 218561 [details]
patch
Comment 2 WebKit Commit Bot 2013-12-05 18:49:23 PST
Comment on attachment 218561 [details]
patch

Clearing flags on attachment: 218561

Committed r160207: <http://trac.webkit.org/changeset/160207>
Comment 3 WebKit Commit Bot 2013-12-05 18:49:26 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2013-12-06 09:24:24 PST
Comment on attachment 218561 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218561&action=review

> Source/WebCore/svg/graphics/SVGImage.h:86
>      // FIXME: SVGImages are underreporting decoded sizes and will be unable
>      // to prune because these functions are not implemented yet.

This comment seems obsolete as well.
Comment 5 Tim Horton 2013-12-06 13:30:59 PST
Yes!
Comment 6 Tim Horton 2013-12-06 13:31:22 PST
Created attachment 218618 [details]
remove comment I missed
Comment 7 Tim Horton 2013-12-06 13:32:48 PST
Created attachment 218620 [details]
leave part that's still true
Comment 8 WebKit Commit Bot 2013-12-06 14:24:31 PST
Comment on attachment 218620 [details]
leave part that's still true

Clearing flags on attachment: 218620

Committed r160248: <http://trac.webkit.org/changeset/160248>
Comment 9 WebKit Commit Bot 2013-12-06 14:24:34 PST
All reviewed patches have been landed.  Closing bug.