Bug 125323 – Clean up the forwarding headers of RenderBlock.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Zoltan Horvath]

In this patch, I removed the unnecessary forwarding headers from RenderBlock.h, and moved some to RenderBlockFlow.h.

[Zoltan Horvath]

Created attachment 218560 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 218560 [details]
Patch

Clearing flags on attachment: 218560

Committed r160209: <http://trac.webkit.org/changeset/160209>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

(In reply to comment #0)
> In this patch, I removed the unnecessary forwarding headers from RenderBlock.h, and moved some to RenderBlockFlow.h.

For what it’s worth, the correct name for these is “forward declarations” rather than “forwarding headers”.

[Zoltan Horvath]

(In reply to comment #4)
> For what it’s worth, the correct name for these is “forward declarations” rather than “forwarding headers”.

Ah, sorry about the typo. I  think removing forward declarations, which are not used anymore in that context, totally makes sense. Some of them weren't used in RenderBlock.h, but only in RenderBlockFlow.h, so moving these to their place makes the code cleaner, and makes easier to figure out what is going on, if you need to deal with them. The work that lead me to do this was about the RenderBlockLineLayout.cpp refactoring, when I tried to use a header as a header somewhere, but the cross-dependencies in the includes/include-orders made it difficult.

[Darin Adler]

Change was great; I am 100% happy with this patch. I was commenting the terminology you were using so you could be clearer next time.

[Zoltan Horvath]

(In reply to comment #6)
> Change was great; I am 100% happy with this patch. I was commenting the terminology you were using so you could be clearer next time.

Thanks for the clarification! I'll pay more attention to use the right terminology next time.