WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125320
[Gtk] install-dependencies doesn't install libgtk-3-dev
https://bugs.webkit.org/show_bug.cgi?id=125320
Summary
[Gtk] install-dependencies doesn't install libgtk-3-dev
Brendan Long
Reported
2013-12-05 15:08:12 PST
I'm using Ubuntu 13.10 and Tools/gtk/install-dependencies misses libgtk-3-dev. I'm not sure if adding this will break earlier Ubuntus though.
Attachments
Patch
(1.60 KB, patch)
2013-12-08 03:54 PST
,
Brendan Long
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brendan Long
Comment 1
2013-12-05 15:15:11 PST
Apparently it's also missing libsoup2.4-dev and libgtk2.0-dev.
Gustavo Noronha (kov)
Comment 2
2013-12-06 07:38:57 PST
I think the reason why we don't install those is two fold: 1) we don't need very new versions of them 2) we build them in our jhbuild. That said, I wouldn't oppose - it looks like we have soup for Fedora, for isntance. As for the APT version, I see libgtk2.0-dev there, so we're missing libgtk-3-dev and libsoup2.4-dev only.
Martin Robinson
Comment 3
2013-12-06 07:51:02 PST
(In reply to
comment #2
)
> I think the reason why we don't install those is two fold: 1) we don't need very new versions of them 2) we build them in our jhbuild. That said, I wouldn't oppose - it looks like we have soup for Fedora, for isntance. > > As for the APT version, I see libgtk2.0-dev there, so we're missing libgtk-3-dev and libsoup2.4-dev only.
Yeah, presumably if you are using install-dependencies you are also using build-webkit.
Brendan Long
Comment 4
2013-12-08 03:54:34 PST
Created
attachment 218680
[details]
Patch I also added a section for webkit-patch dependencies, since it needs subversion apparently.
WebKit Commit Bot
Comment 5
2013-12-08 07:27:33 PST
Comment on
attachment 218680
[details]
Patch Clearing flags on attachment: 218680 Committed
r160285
: <
http://trac.webkit.org/changeset/160285
>
WebKit Commit Bot
Comment 6
2013-12-08 07:27:35 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug