Bug 125320 - [Gtk] install-dependencies doesn't install libgtk-3-dev
Summary: [Gtk] install-dependencies doesn't install libgtk-3-dev
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Minor
Assignee: Brendan Long
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-05 15:08 PST by Brendan Long
Modified: 2013-12-08 07:27 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2013-12-08 03:54 PST, Brendan Long
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Long 2013-12-05 15:08:12 PST
I'm using Ubuntu 13.10 and Tools/gtk/install-dependencies misses libgtk-3-dev. I'm not sure if adding this will break earlier Ubuntus though.
Comment 1 Brendan Long 2013-12-05 15:15:11 PST
Apparently it's also missing libsoup2.4-dev and libgtk2.0-dev.
Comment 2 Gustavo Noronha (kov) 2013-12-06 07:38:57 PST
I think the reason why we don't install those is two fold: 1) we don't need very new versions of them 2) we build them in our jhbuild. That said, I wouldn't oppose - it looks like we have soup for Fedora, for isntance.

As for the APT version, I see libgtk2.0-dev there, so we're missing libgtk-3-dev and libsoup2.4-dev only.
Comment 3 Martin Robinson 2013-12-06 07:51:02 PST
(In reply to comment #2)
> I think the reason why we don't install those is two fold: 1) we don't need very new versions of them 2) we build them in our jhbuild. That said, I wouldn't oppose - it looks like we have soup for Fedora, for isntance.
> 
> As for the APT version, I see libgtk2.0-dev there, so we're missing libgtk-3-dev and libsoup2.4-dev only.

Yeah, presumably if you are using install-dependencies you are also using build-webkit.
Comment 4 Brendan Long 2013-12-08 03:54:34 PST
Created attachment 218680 [details]
Patch

I also added a section for webkit-patch dependencies, since it needs subversion apparently.
Comment 5 WebKit Commit Bot 2013-12-08 07:27:33 PST
Comment on attachment 218680 [details]
Patch

Clearing flags on attachment: 218680

Committed r160285: <http://trac.webkit.org/changeset/160285>
Comment 6 WebKit Commit Bot 2013-12-08 07:27:35 PST
All reviewed patches have been landed.  Closing bug.