Bug 125304 - [GStreamer] Audio/Video sink management is incoherent
Summary: [GStreamer] Audio/Video sink management is incoherent
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-12-05 06:31 PST by Philippe Normand
Modified: 2013-12-06 01:04 PST (History)
8 users (show)

See Also:

patch (9.14 KB, patch)
2013-12-05 10:10 PST, Philippe Normand
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2013-12-05 06:31:57 PST
The API in the base class to configure the sinks is incoherent, a video-sink accessor is also missing.
Comment 1 Philippe Normand 2013-12-05 10:10:42 PST
Created attachment 218521 [details]
Comment 2 Gustavo Noronha (kov) 2013-12-05 10:50:56 PST
Comment on attachment 218521 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=218521&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:505
> +GstElement* MediaPlayerPrivateGStreamerBase::videoSink() const
> +{
> +    return m_fpsSink ? m_fpsSink.get() : m_webkitVideoSink.get();
> +}

This looks unused, will be used in a follow-up patch I guess?
Comment 3 Philippe Normand 2013-12-06 00:33:36 PST
Well I added it for consistency mainly, it's indeed unused. I guess I'll remove it till one day its existence can no longer be avoided :)
Comment 4 Philippe Normand 2013-12-06 01:04:08 PST
Committed r160214: <http://trac.webkit.org/changeset/160214>