The API in the base class to configure the sinks is incoherent, a video-sink accessor is also missing.
Created attachment 218521 [details]
Comment on attachment 218521 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=218521&action=review
> +GstElement* MediaPlayerPrivateGStreamerBase::videoSink() const
> + return m_fpsSink ? m_fpsSink.get() : m_webkitVideoSink.get();
This looks unused, will be used in a follow-up patch I guess?
Well I added it for consistency mainly, it's indeed unused. I guess I'll remove it till one day its existence can no longer be avoided :)
Committed r160214: <http://trac.webkit.org/changeset/160214>