Bug 125291 – [CSS Regions] Implement visual overflow computation for inline elements

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Andrei Bucur]

Currently only RenderBoxes have visual overflow computed per region. This means inline elements are incorrectly handled.

[Andrei Bucur]

Created attachment 220613 [details]
Patch

[Mihai Maerean]

Comment on attachment 220613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220613&action=review

> Source/WebCore/rendering/RenderFlowThread.cpp:845
> +    return object->isBox() || object->isRenderInline();

There's a FIXME in RenderFlowThread::regionForCompositedLayer: "remove this when we'll have region ranges for inlines as well"

> Source/WebCore/rendering/RenderRegion.cpp:718
> +    return LayoutRect(); // FIXME: Should ASSERT_NOT_REACHED here?

Why the FIXME comment? Just add the assert.

[Andrei Bucur]

(In reply to comment #2)
> (From update of attachment 220613 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220613&action=review
> 
> > Source/WebCore/rendering/RenderFlowThread.cpp:845
> > +    return object->isBox() || object->isRenderInline();
> 
> There's a FIXME in RenderFlowThread::regionForCompositedLayer: "remove this when we'll have region ranges for inlines as well"

This patch doesn't provide ranges for inline elements (e.g. a div with display: inline-block), but the means to access the visual overflow in regions for more elements (RenderInlines in this case).

> 
> > Source/WebCore/rendering/RenderRegion.cpp:718
> > +    return LayoutRect(); // FIXME: Should ASSERT_NOT_REACHED here?
> 
> Why the FIXME comment? Just add the assert.

Will do.

[Andrei Bucur]

Created attachment 220637 [details]
Patch

[Mihai Maerean]

Comment on attachment 220637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220637&action=review

> LayoutTests/fast/regions/overflow-in-variable-width-regions-inline.html:39
> +<p>The paragraph inside the regions must be fragmented. Each fragment must be relatively positioned based on the fragment position.</p>

all tests should mention the number of the bug they test.

[Andrei Bucur]

Created attachment 220702 [details]
Patch

[Dave Hyatt]

Comment on attachment 220702 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 220702 [details]
Patch

Clearing flags on attachment: 220702

Committed r161626: <http://trac.webkit.org/changeset/161626>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.