or come up with a better fix
RuleSet has a special case in isCommonAttributeSelectorAttribute for
allowing style sharing on elements that match "type" or "readonly"
attribute selectors as long as they have the same value. This was
added long ago in r96393 and worked based on the assumption that
there was logic in canShareStyleWithElement that actually checked
the value of the type and readonly attributes on the style sharing
Later in r123730 the type attribute handling was regressed when it
was moved to only check the value for <input>. The readonly attribute
was later regressed in the same way in r134984.
This patch restores the checks those two patches moved but retains the
switch from getAttribute to fastGetAttribute for HTML which was likely
most of the performance improvement and fixes the bug where elements
would incorrectly share style even if one of them matched an attribute
Unfortunately this does mean that we need to call the slow geAttribute
in SVG documents which may be a minor regression. We can work to
improve the performance of SVG in the future once we get the
Created attachment 245427 [details]
Comment on attachment 245427 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=245427&action=review
> +Make sure special case style sharing for readonly and type attributes works
Nit: a full stop after "works"
> +description("Make sure special case style sharing for readonly and type attributes works");
Committed r179205: <http://trac.webkit.org/changeset/179205>