Bug 125278 – Save original text for RenderText to a map

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Antti Koivisto]

foo

[Antti Koivisto]

Created attachment 218529 [details]
patch

[Darin Adler]

Comment on attachment 218529 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218529&action=review

Gotta fix the NDEBUG problem. Otherwise looks good to me, and I can’t spot any bugs. Not sure we have sufficient test coverage.

> Source/WebCore/rendering/RenderText.cpp:100
> +typedef HashMap<const RenderText*, String> OriginalTextMap;

Not sure we benefit from using a typedef for this since the type is only used twice. Also extra blank line before this typedef.

> Source/WebCore/rendering/RenderText.cpp:204
>  RenderText::~RenderText()
>  {
> +    if (m_originalTextDiffersFromRendered)
> +        originalTextMap().remove(this);
>  }

We need to take this out of #ifndef NDEBUG since we are going to use it for non-debugging purposes.

[Antti Koivisto]

> We need to take this out of #ifndef NDEBUG since we are going to use it for non-debugging purposes.

oops!

[Build Bot]

Comment on attachment 218529 [details]
patch

Attachment 218529 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/44178030

New failing tests:
svg/text/text-ws-02-t.svg
svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg
svg/W3C-SVG-1.1/text-ws-02-t.svg
svg/custom/text-whitespace-handling.svg

[Build Bot]

Created attachment 218536 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 218529 [details]
patch

Attachment 218529 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/44248028

New failing tests:
svg/text/text-ws-02-t.svg
svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg
svg/W3C-SVG-1.1/text-ws-02-t.svg
svg/custom/text-whitespace-handling.svg

[Build Bot]

Created attachment 218539 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Antti Koivisto]

https://trac.webkit.org/r160259 (with fixes)