Bug 125271 - Cropping and drawing ImageBuffers results in uninitialized data being shown
Summary: Cropping and drawing ImageBuffers results in uninitialized data being shown
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-04 17:57 PST by Myles C. Maxfield
Modified: 2013-12-05 12:41 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.51 KB, patch)
2013-12-04 18:02 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (2.83 KB, patch)
2013-12-04 20:42 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2013-12-04 17:57:52 PST 
Fix r160121
Comment 1 Myles C. Maxfield 2013-12-04 18:02:12 PST 
Created attachment 218476 [details]
Patch
Comment 2 Tim Horton 2013-12-04 18:08:02 PST 
Comment on attachment 218476 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218476&action=review

> Source/WebCore/ChangeLog:3
> +        Fix r160121

terrible bug title!
Comment 3 Myles C. Maxfield 2013-12-04 20:42:52 PST 
Created attachment 218486 [details]
Patch
Comment 4 Simon Fraser (smfr) 2013-12-05 08:54:29 PST 
Comment on attachment 218486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218486&action=review

> Source/WebCore/ChangeLog:14
> +        No new tests are necessary because the existing tests already test this
> +        functionality

Do did the previous commit break tests? You said you had run all the tests.
Comment 5 Myles C. Maxfield 2013-12-05 09:37:34 PST 
Right now, I'm allowing for the possibility of large backing stores; however, ATM no backing stores actually end up being larger than necessary (so the tests didn't pick this up). This patch only comes into play when we allow backing stores to get bigger than needed. After that, then the tests will be sensitive to this patch.
Comment 6 Myles C. Maxfield 2013-12-05 09:38:05 PST 
s/didn't pick this up/didn't break/
Comment 7 WebKit Commit Bot 2013-12-05 12:41:48 PST 
Comment on attachment 218486 [details]
Patch

Clearing flags on attachment: 218486

Committed r160189: <http://trac.webkit.org/changeset/160189>
Comment 8 WebKit Commit Bot 2013-12-05 12:41:50 PST 
All reviewed patches have been landed.  Closing bug.