Bug 125269 – [MSE][Mac] Crash when removing MediaSource from HTMLMediaElement.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[MSE][Mac] Crash when removing MediaSource from HTMLMediaElement.

[Jer Noble]

Created attachment 218474 [details]
Patch

[Jer Noble]

Created attachment 218670 [details]
Patch

[Sam Weinig]

Comment on attachment 218670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218670&action=review

Test case?

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:62
> +    void clearMediaSource() { m_mediaSource = 0; }

nullptr?

[Jer Noble]

(In reply to comment #3)
> (From update of attachment 218670 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218670&action=review
> 
> Test case?

The crash only (reliably) happens with MallocScribble enabled.  But when it is enabled, an existing test crashes.

> > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:62
> > +    void clearMediaSource() { m_mediaSource = 0; }
> 
> nullptr?

Will change.

[Jer Noble]

Committed r160281: <http://trac.webkit.org/changeset/160281>

[Simon Fraser (smfr)]

Could this have caused two tests to show malloc errors?
http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r160286%20(853)/results.html

[Jer Noble]

(In reply to comment #6)
> Could this have caused two tests to show malloc errors?
> http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r160286%20(853)/results.html

It's unlikely; those test cases should never hit MSE code.  But i'll check.