Bug 125268 - Web Inspector: Remove 'cookiesString' output from Page.getCookies
Summary: Web Inspector: Remove 'cookiesString' output from Page.getCookies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Seokju Kwon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-04 17:28 PST by Seokju Kwon
Modified: 2013-12-05 17:06 PST (History)
5 users (show)

See Also:


Attachments
Patch (7.84 KB, patch)
2013-12-04 17:34 PST, Seokju Kwon
no flags Details | Formatted Diff | Diff
Patch (7.83 KB, patch)
2013-12-05 16:05 PST, Seokju Kwon
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Seokju Kwon 2013-12-04 17:28:25 PST
Remove 'cookiesString' output from Page.getCookies protocol.
It is no longer meaningful because it is an unused parameter.
Comment 1 Seokju Kwon 2013-12-04 17:34:10 PST
Created attachment 218473 [details]
Patch
Comment 2 Timothy Hatcher 2013-12-05 09:28:31 PST
Comment on attachment 218473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218473&action=review

> Source/WebCore/inspector/protocol/Page.json:134
> +            "description": "Returns all browser cookies. Depending on the backend support, will return detailed cookie information in the <code>cookie</code> field."

Should be "<code>cookies</code>". It was wrong before this, but we should make it correct now.
Comment 3 Joseph Pecoraro 2013-12-05 10:14:15 PST
Comment on attachment 218473 [details]
Patch

Does any backend still fallback to the string?
Comment 4 Joseph Pecoraro 2013-12-05 10:15:24 PST
Comment on attachment 218473 [details]
Patch

I think you can somewhat close this bug too:
<https://webkit.org/b/80855> Web Inspector: Inspector.getCookies protocol should better reflect parsed/raw alternative return type
Comment 5 Joseph Pecoraro 2013-12-05 10:18:28 PST
(In reply to comment #3)
> (From update of attachment 218473 [details])
> Does any backend still fallback to the string?

To answer my own question, yes, it looks like Curl and Windows at the least do not implement getRawCookies.
Comment 6 Seokju Kwon 2013-12-05 16:05:39 PST
Created attachment 218552 [details]
Patch
Comment 7 Seokju Kwon 2013-12-05 16:07:02 PST
(In reply to comment #2)
> (From update of attachment 218473 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218473&action=review
> 
> > Source/WebCore/inspector/protocol/Page.json:134
> > +            "description": "Returns all browser cookies. Depending on the backend support, will return detailed cookie information in the <code>cookie</code> field."
> 
> Should be "<code>cookies</code>". It was wrong before this, but we should make it correct now.

Thanks. I have uploaded a new patch to fix it.
Comment 8 Seokju Kwon 2013-12-05 16:08:23 PST
(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 218473 [details] [details])
> > Does any backend still fallback to the string?
> 
> To answer my own question, yes, it looks like Curl and Windows at the least do not implement getRawCookies.

Thanks, it look like all ports don't use it.
Comment 9 WebKit Commit Bot 2013-12-05 17:06:18 PST
Comment on attachment 218552 [details]
Patch

Clearing flags on attachment: 218552

Committed r160203: <http://trac.webkit.org/changeset/160203>
Comment 10 WebKit Commit Bot 2013-12-05 17:06:20 PST
All reviewed patches have been landed.  Closing bug.