Bug 125268 – Web Inspector: Remove 'cookiesString' output from Page.getCookies

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Seokju Kwon]

Remove 'cookiesString' output from Page.getCookies protocol.
It is no longer meaningful because it is an unused parameter.

[Seokju Kwon]

Created attachment 218473 [details]
Patch

[Timothy Hatcher]

Comment on attachment 218473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218473&action=review

> Source/WebCore/inspector/protocol/Page.json:134
> +            "description": "Returns all browser cookies. Depending on the backend support, will return detailed cookie information in the <code>cookie</code> field."

Should be "<code>cookies</code>". It was wrong before this, but we should make it correct now.

[Joseph Pecoraro]

Comment on attachment 218473 [details]
Patch

Does any backend still fallback to the string?

[Joseph Pecoraro]

Comment on attachment 218473 [details]
Patch

I think you can somewhat close this bug too:
<https://webkit.org/b/80855> Web Inspector: Inspector.getCookies protocol should better reflect parsed/raw alternative return type

[Joseph Pecoraro]

(In reply to comment #3)
> (From update of attachment 218473 [details])
> Does any backend still fallback to the string?

To answer my own question, yes, it looks like Curl and Windows at the least do not implement getRawCookies.

[Seokju Kwon]

Created attachment 218552 [details]
Patch

[Seokju Kwon]

(In reply to comment #2)
> (From update of attachment 218473 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218473&action=review
> 
> > Source/WebCore/inspector/protocol/Page.json:134
> > +            "description": "Returns all browser cookies. Depending on the backend support, will return detailed cookie information in the <code>cookie</code> field."
> 
> Should be "<code>cookies</code>". It was wrong before this, but we should make it correct now.

Thanks. I have uploaded a new patch to fix it.

[Seokju Kwon]

(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 218473 [details] [details])
> > Does any backend still fallback to the string?
> 
> To answer my own question, yes, it looks like Curl and Windows at the least do not implement getRawCookies.

Thanks, it look like all ports don't use it.

[WebKit Commit Bot]

Comment on attachment 218552 [details]
Patch

Clearing flags on attachment: 218552

Committed r160203: <http://trac.webkit.org/changeset/160203>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.