Bug 125260 – Web Inspector: ColorWheel uses old Color constructor

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Antoine Quint]

The Color constructor changed in http://trac.webkit.org/changeset/160132 but ColorWheel still uses the old signature.

[Antoine Quint]

Created attachment 218463 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 218463 [details]
Patch

Isn't 0 black? Shouldn't this be 255, 255, 255, 0? r-

[Joseph Pecoraro]

Comment on attachment 218463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218463&action=review

> Source/WebInspectorUI/UserInterface/ColorWheel.js:103
> +        return new WebInspector.Color(WebInspector.Color.Format.RGBA, [0, 0, 0, 0]);

Shouldn't this be [255, 255, 255, 0]?

[Antoine Quint]

(In reply to comment #3)
> (From update of attachment 218463 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218463&action=review
> 
> > Source/WebInspectorUI/UserInterface/ColorWheel.js:103
> > +        return new WebInspector.Color(WebInspector.Color.Format.RGBA, [0, 0, 0, 0]);
> 
> Shouldn't this be [255, 255, 255, 0]?

Since the alpha bit is 0, I don't think it makes any difference, it's a clear color anyway.

[Joseph Pecoraro]

Comment on attachment 218463 [details]
Patch

Ahh, gotcha. I should have read the change log closer to see the intent. Thanks!

[WebKit Commit Bot]

Comment on attachment 218463 [details]
Patch

Clearing flags on attachment: 218463

Committed r160145: <http://trac.webkit.org/changeset/160145>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.