Bug 125260 - Web Inspector: ColorWheel uses old Color constructor
Summary: Web Inspector: ColorWheel uses old Color constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-04 15:24 PST by Antoine Quint
Modified: 2013-12-04 16:49 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2013-12-04 15:26 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2013-12-04 15:24:35 PST 
The Color constructor changed in http://trac.webkit.org/changeset/160132 but ColorWheel still uses the old signature.
Comment 1 Antoine Quint 2013-12-04 15:26:24 PST 
Created attachment 218463 [details]
Patch
Comment 2 Joseph Pecoraro 2013-12-04 15:41:36 PST 
Comment on attachment 218463 [details]
Patch

Isn't 0 black? Shouldn't this be 255, 255, 255, 0? r-
Comment 3 Joseph Pecoraro 2013-12-04 15:42:51 PST 
Comment on attachment 218463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218463&action=review

> Source/WebInspectorUI/UserInterface/ColorWheel.js:103
> +        return new WebInspector.Color(WebInspector.Color.Format.RGBA, [0, 0, 0, 0]);

Shouldn't this be [255, 255, 255, 0]?
Comment 4 Antoine Quint 2013-12-04 15:51:36 PST 
(In reply to comment #3)
> (From update of attachment 218463 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218463&action=review
> 
> > Source/WebInspectorUI/UserInterface/ColorWheel.js:103
> > +        return new WebInspector.Color(WebInspector.Color.Format.RGBA, [0, 0, 0, 0]);
> 
> Shouldn't this be [255, 255, 255, 0]?

Since the alpha bit is 0, I don't think it makes any difference, it's a clear color anyway.
Comment 5 Joseph Pecoraro 2013-12-04 16:21:46 PST 
Comment on attachment 218463 [details]
Patch

Ahh, gotcha. I should have read the change log closer to see the intent. Thanks!
Comment 6 WebKit Commit Bot 2013-12-04 16:49:45 PST 
Comment on attachment 218463 [details]
Patch

Clearing flags on attachment: 218463

Committed r160145: <http://trac.webkit.org/changeset/160145>
Comment 7 WebKit Commit Bot 2013-12-04 16:49:47 PST 
All reviewed patches have been landed.  Closing bug.