Bug 125259 - Make the estimatedProgress property observable using KVO
Summary: Make the estimatedProgress property observable using KVO
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-04 15:15 PST by Anders Carlsson
Modified: 2013-12-04 15:40 PST (History)
0 users

See Also:


Attachments
Patch (12.98 KB, patch)
2013-12-04 15:16 PST, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-12-04 15:15:04 PST
Make the estimatedProgress property observable using KVO
Comment 1 Anders Carlsson 2013-12-04 15:16:38 PST
Created attachment 218461 [details]
Patch
Comment 2 mitz 2013-12-04 15:34:44 PST
Comment on attachment 218461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218461&action=review

> Source/WebKit2/UIProcess/PageLoadState.cpp:73
> +    m_estimatedProgress = 0.0;

No need for “.0”. Should we be doing this if the value is already 0?

> Source/WebKit2/UIProcess/PageLoadState.cpp:234
> +    m_estimatedProgress = 1.0;

No need for “.0” here.
Comment 3 Anders Carlsson 2013-12-04 15:40:45 PST
Committed r160137: <http://trac.webkit.org/changeset/160137>