RESOLVED FIXED 125256
Add a loading property to WKBrowsingContextController 
https://bugs.webkit.org/show_bug.cgi?id=125256
Summary Add a loading property to WKBrowsingContextController
Anders Carlsson
Reported 2013-12-04 14:32:57 PST
Add a loading property to WKBrowsingContextController
Attachments
Patch (9.93 KB, patch)
2013-12-04 14:38 PST, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-12-04 14:38:22 PST
Created attachment 218450 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-04 14:40:17 PST
Attachment 218450 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/PageLoadState.cpp', u'Source/WebKit2/UIProcess/PageLoadState.h', u'Tools/ChangeLog', u'Tools/MiniBrowser/mac/WK2BrowserWindowController.m', '--commit-queue']" exit_code: 1 ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h:109: Missing spaces around = [whitespace/operators] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2013-12-04 14:42:29 PST
Comment on attachment 218450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218450&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.h:109 > +@property (nonatomic, readonly, getter=isLoading) BOOL loading; I think “nonatomic” is meaningless here. > Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm:84 > + No need for this line.
Anders Carlsson
Comment 4 2013-12-04 14:48:48 PST
Committed r160129: <http://trac.webkit.org/changeset/160129>
Note You need to log in before you can comment on or make changes to this bug.