Bug 125231 – [EFL][GTK][WK2] Remove unnecessary reinterpret_casts when setting API clients

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Nick Diego Yamane (diegoyam)]

Bug 125182 changed modified GTK and EFL API Clients to follow the new API::Client implementation.
It introduced some unnecessary reinterpret_casts when setting those clients. This bug is for removing them.

[Nick Diego Yamane (diegoyam)]

Created attachment 218425 [details]
Patch

[Nick Diego Yamane (diegoyam)]

Created attachment 218426 [details]
Rebased patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

Comment on attachment 218426 [details]
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218426&action=review

Looks good apart from the ChangeLog weirdness.

> Source/WebKit2/ChangeLog:72
> +        * UIProcess/API/gtk/WebKitFullscreenClient.cpp:
> +        (attachFullScreenClientToView):
> +        * UIProcess/API/gtk/WebKitRequestManagerClient.cpp:
> +        (attachRequestManagerClientToContext):
> +        * UIProcess/API/gtk/WebKitTextChecker.cpp:
> +        (WebKitTextChecker::WebKitTextChecker):
> +        * UIProcess/API/gtk/WebKitWebInspector.cpp:
> +        (webkitWebInspectorCreate):
> +        * UIProcess/efl/BatteryProvider.cpp:
> +        (BatteryProvider::BatteryProvider):
> +        * UIProcess/efl/NetworkInfoProvider.cpp:
> +        (NetworkInfoProvider::NetworkInfoProvider):
> +        * UIProcess/efl/RequestManagerClientEfl.cpp:
> +        (WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
> +        * UIProcess/efl/TextCheckerClientEfl.cpp:
> +        (TextCheckerClientEfl::TextCheckerClientEfl):
> +        * UIProcess/efl/VibrationClientEfl.cpp:
> +        (VibrationClientEfl::VibrationClientEfl):
> +        * UIProcess/efl/ViewClientEfl.cpp:

It seems wrong to update an old ChangeLog entry.

[Nick Diego Yamane (diegoyam)]

(In reply to comment #4)
> (From update of attachment 218426 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218426&action=review
> 
> Looks good apart from the ChangeLog weirdness.
> 
> > Source/WebKit2/ChangeLog:72
> > +        * UIProcess/API/gtk/WebKitFullscreenClient.cpp:
> > +        (attachFullScreenClientToView):
> > +        * UIProcess/API/gtk/WebKitRequestManagerClient.cpp:
> > +        (attachRequestManagerClientToContext):
> > +        * UIProcess/API/gtk/WebKitTextChecker.cpp:
> > +        (WebKitTextChecker::WebKitTextChecker):
> > +        * UIProcess/API/gtk/WebKitWebInspector.cpp:
> > +        (webkitWebInspectorCreate):
> > +        * UIProcess/efl/BatteryProvider.cpp:
> > +        (BatteryProvider::BatteryProvider):
> > +        * UIProcess/efl/NetworkInfoProvider.cpp:
> > +        (NetworkInfoProvider::NetworkInfoProvider):
> > +        * UIProcess/efl/RequestManagerClientEfl.cpp:
> > +        (WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
> > +        * UIProcess/efl/TextCheckerClientEfl.cpp:
> > +        (TextCheckerClientEfl::TextCheckerClientEfl):
> > +        * UIProcess/efl/VibrationClientEfl.cpp:
> > +        (VibrationClientEfl::VibrationClientEfl):
> > +        * UIProcess/efl/ViewClientEfl.cpp:
> 
> It seems wrong to update an old ChangeLog entry.

Oops, maybe the git rebase has done this :(

I'll fix that.

But it looks like there are other build issues, probably result from r160104.
I'll try to fix that firstly.

[Nick Diego Yamane (diegoyam)]

Created attachment 218447 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 218447 [details]
Patch

Clearing flags on attachment: 218447

Committed r160128: <http://trac.webkit.org/changeset/160128>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.