WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125226
Remove duplicated/dead code from cpp style checker unit tests.
https://bugs.webkit.org/show_bug.cgi?id=125226
Summary
Remove duplicated/dead code from cpp style checker unit tests.
Tamas Gergely
Reported
2013-12-04 09:23:18 PST
There are two test classes in webkitpy/style/checkers/cpp_unittest.py with the same name. The second overrides the first which can be removed.
Attachments
Remove dead code.
(2.92 KB, patch)
2013-12-04 09:29 PST
,
Tamas Gergely
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tamas Gergely
Comment 1
2013-12-04 09:29:39 PST
Created
attachment 218412
[details]
Remove dead code.
Peter Gal
Comment 2
2013-12-05 02:34:08 PST
Good catch! LGTM :)
WebKit Commit Bot
Comment 3
2013-12-05 03:57:59 PST
Comment on
attachment 218412
[details]
Remove dead code. Clearing flags on attachment: 218412 Committed
r160167
: <
http://trac.webkit.org/changeset/160167
>
WebKit Commit Bot
Comment 4
2013-12-05 03:58:01 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug