Bug 125226 - Remove duplicated/dead code from cpp style checker unit tests.
Summary: Remove duplicated/dead code from cpp style checker unit tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-04 09:23 PST by Tamas Gergely
Modified: 2013-12-05 03:58 PST (History)
5 users (show)

See Also:


Attachments
Remove dead code. (2.92 KB, patch)
2013-12-04 09:29 PST, Tamas Gergely
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Gergely 2013-12-04 09:23:18 PST
There are two test classes in webkitpy/style/checkers/cpp_unittest.py with the same name. The second overrides the first which can be removed.
Comment 1 Tamas Gergely 2013-12-04 09:29:39 PST
Created attachment 218412 [details]
Remove dead code.
Comment 2 Peter Gal 2013-12-05 02:34:08 PST
Good catch! LGTM :)
Comment 3 WebKit Commit Bot 2013-12-05 03:57:59 PST
Comment on attachment 218412 [details]
Remove dead code.

Clearing flags on attachment: 218412

Committed r160167: <http://trac.webkit.org/changeset/160167>
Comment 4 WebKit Commit Bot 2013-12-05 03:58:01 PST
All reviewed patches have been landed.  Closing bug.