Bug 125223 - Fix handling of 'inherit' and 'initial' for grid lines
Summary: Fix handling of 'inherit' and 'initial' for grid lines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-12-04 07:28 PST by Peter Molnar
Modified: 2013-12-09 11:42 PST (History)
12 users (show)

See Also:

Attachments
Patch (26.10 KB, patch)
2013-12-04 07:31 PST, Peter Molnar 		no flags Details | Formatted Diff | Diff
Patch - ChangeLog updated (27.08 KB, patch)
2013-12-09 04:38 PST, Peter Molnar 		no flags Details | Formatted Diff | Diff
Patch - ChangeLog fixed (27.08 KB, patch)
2013-12-09 05:28 PST, Peter Molnar 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Molnar 2013-12-04 07:28:32 PST 
'initial' and 'inherit' are always allowed values for CSS properties.
As the CSSParser handles them automatically, those 2 values were never
taken care of in StyleResolver.

Fix backported from Blink, without the refactoring in the same patch:
https://src.chromium.org/viewvc/blink?revision=149257&view=revision
Comment 1 Peter Molnar 2013-12-04 07:31:56 PST 
Created attachment 218409 [details]
Patch
Comment 2 Zoltan Herczeg 2013-12-09 01:29:41 PST 
This patch looks good, but let's wait a little maybe others have comments. Please elaborate more about this change in the ChangeLog.
Comment 3 Peter Molnar 2013-12-09 04:38:06 PST 
Created attachment 218749 [details]
Patch - ChangeLog updated
Comment 4 WebKit Commit Bot 2013-12-09 04:38:47 PST 
Attachment 218749 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set-expected.txt', u'LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html', u'LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set-expected.txt', u'LayoutTests/fast/css-grid-layout/grid-item-end-after-get-set.html', u'LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set-expected.txt', u'LayoutTests/fast/css-grid-layout/grid-item-start-before-get-set.html', u'LayoutTests/fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/rendering/style/RenderStyle.h', u'Source/WebCore/rendering/style/StyleGridItemData.cpp', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/ChangeLog:14:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:16:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Peter Molnar 2013-12-09 05:28:25 PST 
Created attachment 218750 [details]
Patch - ChangeLog fixed
Comment 6 WebKit Commit Bot 2013-12-09 11:42:21 PST 
Comment on attachment 218750 [details]
Patch - ChangeLog fixed

Clearing flags on attachment: 218750

Committed r160322: <http://trac.webkit.org/changeset/160322>
Comment 7 WebKit Commit Bot 2013-12-09 11:42:23 PST 
All reviewed patches have been landed.  Closing bug.