Bug 125208 - bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless
Summary: bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-12-03 20:49 PST by Ryosuke Niwa
Modified: 2013-12-04 19:54 PST (History)
7 users (show)

See Also:

Attachments
Removes the member functions (10.21 KB, patch)
2013-12-03 20:53 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-12-03 20:49:07 PST 
Merge https://chromium.googlesource.com/chromium/blink/+/49b1eeabbbf573d5271288c66d2b566cf33a09cf

No one should ever use the vlink/link/text/alink and other color attribute
methods on HTMLBodyElement in C++ code, and the bindings for HTMLBodyElement
are set to Reflect so they never go through these methods anyway. They only
existed to support the code in HTMLDocument.cpp. Instead we can contain all
the logic there and also simplify these methods greatly letting us delete
a bunch of code.
Comment 1 Ryosuke Niwa 2013-12-03 20:53:07 PST 
Created attachment 218380 [details]
Removes the member functions
Comment 2 WebKit Commit Bot 2013-12-03 23:41:53 PST 
Comment on attachment 218380 [details]
Removes the member functions

Clearing flags on attachment: 218380

Committed r160072: <http://trac.webkit.org/changeset/160072>
Comment 3 WebKit Commit Bot 2013-12-03 23:41:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2013-12-04 11:52:35 PST 
Comment on attachment 218380 [details]
Removes the member functions

View in context: https://bugs.webkit.org/attachment.cgi?id=218380&action=review

> Source/WebCore/html/HTMLDocument.cpp:166
> +    return bodyElement->getAttribute(bgcolorAttr);

Could be fastGetAttribute.

> Source/WebCore/html/HTMLDocument.cpp:182
> +    return bodyElement->getAttribute(textAttr);

Could be fastGetAttribute.

> Source/WebCore/html/HTMLDocument.cpp:198
> +    return bodyElement->getAttribute(alinkAttr);

Could be fastGetAttribute.

> Source/WebCore/html/HTMLDocument.cpp:214
> +    return bodyElement->getAttribute(linkAttr);

Could be fastGetAttribute.

> Source/WebCore/html/HTMLDocument.cpp:230
> +    return bodyElement->getAttribute(vlinkAttr);

Could be fastGetAttribute.
Comment 5 Ryosuke Niwa 2013-12-04 19:54:17 PST 
Committed r160157: <http://trac.webkit.org/changeset/160157>