Bug 125208 – bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Merge https://chromium.googlesource.com/chromium/blink/+/49b1eeabbbf573d5271288c66d2b566cf33a09cf

No one should ever use the vlink/link/text/alink and other color attribute
methods on HTMLBodyElement in C++ code, and the bindings for HTMLBodyElement
are set to Reflect so they never go through these methods anyway. They only
existed to support the code in HTMLDocument.cpp. Instead we can contain all
the logic there and also simplify these methods greatly letting us delete
a bunch of code.

[Ryosuke Niwa]

Created attachment 218380 [details]
Removes the member functions

[WebKit Commit Bot]

Comment on attachment 218380 [details]
Removes the member functions

Clearing flags on attachment: 218380

Committed r160072: <http://trac.webkit.org/changeset/160072>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 218380 [details]
Removes the member functions

View in context: https://bugs.webkit.org/attachment.cgi?id=218380&action=review

> Source/WebCore/html/HTMLDocument.cpp:166
> +    return bodyElement->getAttribute(bgcolorAttr);

Could be fastGetAttribute.

> Source/WebCore/html/HTMLDocument.cpp:182
> +    return bodyElement->getAttribute(textAttr);

Could be fastGetAttribute.

> Source/WebCore/html/HTMLDocument.cpp:198
> +    return bodyElement->getAttribute(alinkAttr);

Could be fastGetAttribute.

> Source/WebCore/html/HTMLDocument.cpp:214
> +    return bodyElement->getAttribute(linkAttr);

Could be fastGetAttribute.

> Source/WebCore/html/HTMLDocument.cpp:230
> +    return bodyElement->getAttribute(vlinkAttr);

Could be fastGetAttribute.

[Ryosuke Niwa]

Committed r160157: <http://trac.webkit.org/changeset/160157>