Bug 125206 - [EFL][WK2] Fix build after API::Client changes
Summary: [EFL][WK2] Fix build after API::Client changes
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nick Diego Yamane (diegoyam)
: 125182 (view as bug list)
Depends on: 125182
  Show dependency treegraph
Reported: 2013-12-03 18:53 PST by Nick Diego Yamane (diegoyam)
Modified: 2013-12-04 02:56 PST (History)
15 users (show)

See Also:

Patch (81.49 KB, patch)
2013-12-03 20:37 PST, Nick Diego Yamane (diegoyam)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Diego Yamane (diegoyam) 2013-12-03 18:53:21 PST
Bug 125129 changed the way WK2 API::ClientTraits are implemented, to use a template-based approach.
After that EFL WK2 build is broken. To fix that we should make modifications similar to what is being done in bug 125129 and bug 125182.
Comment 1 Nick Diego Yamane (diegoyam) 2013-12-03 20:37:34 PST
Created attachment 218379 [details]

EFL changes including the changes from bug 125182, which this bug depends on. Initially to see the buildbot results.
Comment 2 WebKit Commit Bot 2013-12-03 20:39:50 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Csaba Osztrogonác 2013-12-04 00:46:00 PST
Comment on attachment 218379 [details]

I'm not 100% sure if it is the proper change. But we don't know anything about
the original change and its author and WK2 owners are unreachable. :((

So r=me to fix the build as soon as possible. We can always revise
the patch later if we get feedback from WK2 owners.
Comment 4 Csaba Osztrogonác 2013-12-04 00:55:58 PST
landed in http://trac.webkit.org/changeset/160075
Comment 5 Gustavo Noronha (kov) 2013-12-04 02:56:27 PST
*** Bug 125182 has been marked as a duplicate of this bug. ***