Bug 125205 – Fold constant typed arrays

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming, after https://bugs.webkit.org/show_bug.cgi?id=124630 lands.

[Filip Pizlo]

Created attachment 218377 [details]
it begins

[Filip Pizlo]

Created attachment 218430 [details]
it does some of the things

[Filip Pizlo]

Created attachment 218457 [details]
the patch

[WebKit Commit Bot]

Attachment 218457 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/js/regress/fixed-typed-array-storage-expected.txt', u'LayoutTests/js/regress/fixed-typed-array-storage-var-index-expected.txt', u'LayoutTests/js/regress/fixed-typed-array-storage-var-index.html', u'LayoutTests/js/regress/fixed-typed-array-storage.html', u'LayoutTests/js/regress/script-tests/fixed-typed-array-storage-var-index.js', u'LayoutTests/js/regress/script-tests/fixed-typed-array-storage.js', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/dfg/DFGDesiredWatchpoints.cpp', u'Source/JavaScriptCore/dfg/DFGDesiredWatchpoints.h', u'Source/JavaScriptCore/dfg/DFGGraph.cpp', u'Source/JavaScriptCore/dfg/DFGGraph.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGWatchpointCollectionPhase.cpp', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp', u'Source/JavaScriptCore/runtime/ArrayBuffer.cpp', u'Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpoint.cpp', u'Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpoint.h', u'Source/JavaScriptCore/runtime/VM.cpp', u'Source/JavaScriptCore/runtime/VM.h', '--commit-queue']" exit_code: 1
ERROR: Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpoint.cpp:39:  Comma should be at the beggining of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Hahnenberg]

Comment on attachment 218457 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218457&action=review

r=me too

> Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpoint.cpp:49
> +ArrayBufferNeuteringWatchpoint::~ArrayBufferNeuteringWatchpoint() { }
> +
> +void ArrayBufferNeuteringWatchpoint::finishCreation(VM& vm)
> +{
> +    Base::finishCreation(vm);
> +}

Not necessary.

> Source/JavaScriptCore/runtime/ArrayBufferNeuteringWatchpoint.h:42
> +    ~ArrayBufferNeuteringWatchpoint();
> +    
> +    void finishCreation(VM&);

Ditto.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/160150