Bug 125200 - Rename DragImage to PlatformImage
Summary: Rename DragImage to PlatformImage
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 124325
  Show dependency tree / graph
 
Reported: 2013-12-03 16:33 PST by Brian Burg
Modified: 2017-01-18 23:39 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2013-12-03 16:33:56 PST 
DragImage.h and the functions in it are used in lots of places besides dragging code. It should be renamed to something like RenderedImage while retaining platform typedefs. Then, dragging-related callsites can pass parameters to enable drag-specific rendering.
Comment 1 Brian Burg 2013-12-04 10:26:28 PST 
I would like feedback on this before I go do 500 renamings. What should we do about functions that are only used for dragging (in particular, link and image previews, and the various scaling/dissolving ops)? Should they be named createRenderedImageForLink? In that case, it's implicit that they are doing some extra rendering to make it look pretty for dragging. Maybe the drag-specific things can stay in DragImage.h and non-drag things (and the typedef) can go into RenderedImage.h
Comment 2 Simon Fraser (smfr) 2013-12-04 13:02:41 PST 
DragImageRef could be PlatformImageRef. It doesn't really have anything to do with renderers.
Comment 3 Brian Burg 2013-12-04 13:31:36 PST 
(In reply to comment #2)
> DragImageRef could be PlatformImageRef. It doesn't really have anything to do with renderers.

That makes sense. So it would be similar to PlatformLayer, then.