NEW 125200
Rename DragImage to PlatformImage 
https://bugs.webkit.org/show_bug.cgi?id=125200
Summary Rename DragImage to PlatformImage
Brian Burg
Reported 2013-12-03 16:33:56 PST
DragImage.h and the functions in it are used in lots of places besides dragging code. It should be renamed to something like RenderedImage while retaining platform typedefs. Then, dragging-related callsites can pass parameters to enable drag-specific rendering.
Attachments
Add attachment proposed patch, testcase, etc.
Brian Burg
Comment 1 2013-12-04 10:26:28 PST
I would like feedback on this before I go do 500 renamings. What should we do about functions that are only used for dragging (in particular, link and image previews, and the various scaling/dissolving ops)? Should they be named createRenderedImageForLink? In that case, it's implicit that they are doing some extra rendering to make it look pretty for dragging. Maybe the drag-specific things can stay in DragImage.h and non-drag things (and the typedef) can go into RenderedImage.h
Simon Fraser (smfr)
Comment 2 2013-12-04 13:02:41 PST
DragImageRef could be PlatformImageRef. It doesn't really have anything to do with renderers.
Brian Burg
Comment 3 2013-12-04 13:31:36 PST
(In reply to comment #2) > DragImageRef could be PlatformImageRef. It doesn't really have anything to do with renderers. That makes sense. So it would be similar to PlatformLayer, then.
Note You need to log in before you can comment on or make changes to this bug.