RESOLVED FIXED 125183
[Cocoa] Give two load delegate methods more conventional names 
https://bugs.webkit.org/show_bug.cgi?id=125183
Summary [Cocoa] Give two load delegate methods more conventional names
mitz
Reported 2013-12-03 14:15:35 PST
[Cocoa] Give two load delegate methods more conventional names
Attachments
Rename load error delegate methods (4.40 KB, patch)
2013-12-03 14:17 PST, mitz 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2013-12-03 14:17:44 PST
Created attachment 218340 [details] Rename load error delegate methods
mitz
Comment 2 2013-12-03 14:29:46 PST
Committed <http://trac.webkit.org/r160040>.
Simon Fraser (smfr)
Comment 3 2013-12-03 22:42:17 PST
This appears to have caused the WKBrowsingContextLoadDelegateTest.SimpleLoadFail unit test to start timing out: http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29?numbuilds=100
mitz
Comment 4 2013-12-03 22:44:04 PST
(In reply to comment #3) > This appears to have caused the WKBrowsingContextLoadDelegateTest.SimpleLoadFail unit test to start timing out: > http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29?numbuilds=100 I must have missed the fact that the test uses a renamed method. I’ll update it.
mitz
Comment 5 2013-12-03 22:48:14 PST
(In reply to comment #4) > (In reply to comment #3) > > This appears to have caused the WKBrowsingContextLoadDelegateTest.SimpleLoadFail unit test to start timing out: > > http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29?numbuilds=100 > > I must have missed the fact that the test uses a renamed method. I’ll update it. Committed <http://trac.webkit.org/r160071>.
Note You need to log in before you can comment on or make changes to this bug.