Bug 125183 - [Cocoa] Give two load delegate methods more conventional names
Summary: [Cocoa] Give two load delegate methods more conventional names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-03 14:15 PST by mitz
Modified: 2013-12-03 22:48 PST (History)
1 user (show)

See Also:

Attachments
Rename load error delegate methods (4.40 KB, patch)
2013-12-03 14:17 PST, mitz 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2013-12-03 14:15:35 PST 
[Cocoa] Give two load delegate methods more conventional names
Comment 1 mitz 2013-12-03 14:17:44 PST 
Created attachment 218340 [details]
Rename load error delegate methods
Comment 2 mitz 2013-12-03 14:29:46 PST 
Committed <http://trac.webkit.org/r160040>.
Comment 3 Simon Fraser (smfr) 2013-12-03 22:42:17 PST 
This appears to have caused the WKBrowsingContextLoadDelegateTest.SimpleLoadFail unit test to start timing out:
http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29?numbuilds=100
Comment 4 mitz 2013-12-03 22:44:04 PST 
(In reply to comment #3)
> This appears to have caused the WKBrowsingContextLoadDelegateTest.SimpleLoadFail unit test to start timing out:
> http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29?numbuilds=100

I must have missed the fact that the test uses a renamed method. I’ll update it.
Comment 5 mitz 2013-12-03 22:48:14 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > This appears to have caused the WKBrowsingContextLoadDelegateTest.SimpleLoadFail unit test to start timing out:
> > http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29?numbuilds=100
> 
> I must have missed the fact that the test uses a renamed method. I’ll update it.

Committed <http://trac.webkit.org/r160071>.