Bug 125179 - [Win] Support 64-bit Application Support Libraries Location
Summary: [Win] Support 64-bit Application Support Libraries Location
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
Depends on:
Blocks: 125180
  Show dependency treegraph
Reported: 2013-12-03 13:23 PST by Brent Fulgham
Modified: 2013-12-03 13:48 PST (History)
2 users (show)

See Also:

Patch (2.60 KB, patch)
2013-12-03 13:36 PST, Brent Fulgham
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-12-03 13:23:53 PST
Currently we don't expect WebKit users on Windows to be working with 64-bit builds. Our test infrastructure needs a way to support 32-bit and 64-bit runtimes so that we can develop and test these configurations.

For now, use an environment variable WEBKIT_64_SUPPORT to specify the path to 64-bit versions of libxml2.dll, libxslt.dll, etc.  In the future, these will be available someplace like "C:\Program Files\..." and we can remove this code.
Comment 1 Brent Fulgham 2013-12-03 13:36:37 PST
Created attachment 218333 [details]
Comment 2 Tim Horton 2013-12-03 13:39:44 PST
Comment on attachment 218333 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=218333&action=review

> Tools/ChangeLog:10
> +        to speficy these locations.


> Tools/Scripts/webkitdirs.pm:1577
> +    # FIXME: Remove the following in https://webkit.org/b/125180

maybe these should say "FIXME (125180): Remove this temporary workaround" or something. Not sure the style.

> Tools/Scripts/webkitdirs.pm:1614
> +    print "WEBKIT_64_SUPPORT is set to: ", $ENV{"WEBKIT_64_SUPPORT"}, "\n" if isWin64(); #FIXME: Remove in https://webkit.org/b/125180

space after #

> Tools/Scripts/webkitdirs.pm:2128
> +        return $ENV{"WEBKIT_64_SUPPORT"}, "\n" if isWin64(); #FIXME: Remove in https://webkit.org/b/125180

space after #
Comment 3 Brent Fulgham 2013-12-03 13:48:04 PST
Committed r160035: <http://trac.webkit.org/changeset/160035>