RESOLVED FIXED 125175
Web Inspector: [CSS Shapes] Highlight margin-shape for shape-outside
https://bugs.webkit.org/show_bug.cgi?id=125175
Summary Web Inspector: [CSS Shapes] Highlight margin-shape for shape-outside
Bear Travis
Reported 2013-12-03 11:55:03 PST
When shape-outside and shape-margin are present, both the shape, and the shape with margin applied should display in the inspector.
Attachments
Initial patch (20.34 KB, patch)
2013-12-03 12:55 PST, Bear Travis
no flags
Updating patch to include image shapes (21.41 KB, patch)
2013-12-04 18:13 PST, Bear Travis
no flags
Renaming to buildDisplayPaths (20.85 KB, patch)
2013-12-05 11:31 PST, Bear Travis
no flags
Updated patch (20.86 KB, patch)
2013-12-05 16:36 PST, Bear Travis
no flags
Updated test to work with more formats (22.28 KB, patch)
2013-12-09 10:53 PST, Bear Travis
no flags
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (504.82 KB, application/zip)
2013-12-09 12:49 PST, Build Bot
no flags
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (449.46 KB, application/zip)
2013-12-09 12:54 PST, Build Bot
no flags
Test fixup (22.84 KB, patch)
2013-12-10 22:55 PST, Bear Travis
no flags
Bear Travis
Comment 1 2013-12-03 12:55:14 PST
Created attachment 218328 [details] Initial patch
Bear Travis
Comment 2 2013-12-04 18:13:52 PST
Created attachment 218479 [details] Updating patch to include image shapes
Bear Travis
Comment 3 2013-12-05 11:31:24 PST
Created attachment 218525 [details] Renaming to buildDisplayPaths
EFL EWS Bot
Comment 4 2013-12-05 11:54:42 PST
Comment on attachment 218525 [details] Renaming to buildDisplayPaths Attachment 218525 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/42718115
Bear Travis
Comment 5 2013-12-05 16:36:36 PST
Created attachment 218553 [details] Updated patch
Bear Travis
Comment 6 2013-12-09 10:53:48 PST
Created attachment 218777 [details] Updated test to work with more formats
Joseph Pecoraro
Comment 7 2013-12-09 11:52:54 PST
Comment on attachment 218777 [details] Updated test to work with more formats View in context: https://bugs.webkit.org/attachment.cgi?id=218777&action=review Drive by comments that don't need to be addressed. Nice patch. > Source/WebCore/inspector/InspectorOverlay.cpp:614 > - shapeObject->setArray("path", shapePath.release()); > + shapeObject->setArray("shape", shapePath.release()); Not new to this patch but we should start using ASCIILiteral for InspectorValue->set calls. Since the string literal is being turned into a WTF::String. > LayoutTests/inspector-protocol/resources/shape-info-helper.js:52 > + return (typeof actual == 'number' Nit: == -> ===
Build Bot
Comment 8 2013-12-09 12:49:09 PST
Comment on attachment 218777 [details] Updated test to work with more formats Attachment 218777 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/47268162 New failing tests: inspector-protocol/model/highlight-shape-outside-margin.html
Build Bot
Comment 9 2013-12-09 12:49:11 PST
Created attachment 218790 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 10 2013-12-09 12:54:15 PST
Comment on attachment 218777 [details] Updated test to work with more formats Attachment 218777 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/47308177 New failing tests: inspector-protocol/model/highlight-shape-outside-margin.html
Build Bot
Comment 11 2013-12-09 12:54:18 PST
Created attachment 218791 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Bear Travis
Comment 12 2013-12-10 22:55:34 PST
Created attachment 218934 [details] Test fixup
WebKit Commit Bot
Comment 13 2013-12-11 13:30:03 PST
Comment on attachment 218934 [details] Test fixup Clearing flags on attachment: 218934 Committed r160451: <http://trac.webkit.org/changeset/160451>
WebKit Commit Bot
Comment 14 2013-12-11 13:30:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.