When shape-outside and shape-margin are present, both the shape, and the shape with margin applied should display in the inspector.
Created attachment 218328 [details] Initial patch
Created attachment 218479 [details] Updating patch to include image shapes
Created attachment 218525 [details] Renaming to buildDisplayPaths
Comment on attachment 218525 [details] Renaming to buildDisplayPaths Attachment 218525 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/42718115
Created attachment 218553 [details] Updated patch
Created attachment 218777 [details] Updated test to work with more formats
Comment on attachment 218777 [details] Updated test to work with more formats View in context: https://bugs.webkit.org/attachment.cgi?id=218777&action=review Drive by comments that don't need to be addressed. Nice patch. > Source/WebCore/inspector/InspectorOverlay.cpp:614 > - shapeObject->setArray("path", shapePath.release()); > + shapeObject->setArray("shape", shapePath.release()); Not new to this patch but we should start using ASCIILiteral for InspectorValue->set calls. Since the string literal is being turned into a WTF::String. > LayoutTests/inspector-protocol/resources/shape-info-helper.js:52 > + return (typeof actual == 'number' Nit: == -> ===
Comment on attachment 218777 [details] Updated test to work with more formats Attachment 218777 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/47268162 New failing tests: inspector-protocol/model/highlight-shape-outside-margin.html
Created attachment 218790 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 218777 [details] Updated test to work with more formats Attachment 218777 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/47308177 New failing tests: inspector-protocol/model/highlight-shape-outside-margin.html
Created attachment 218791 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 218934 [details] Test fixup
Comment on attachment 218934 [details] Test fixup Clearing flags on attachment: 218934 Committed r160451: <http://trac.webkit.org/changeset/160451>
All reviewed patches have been landed. Closing bug.