When compiling testapi.mm for i386 to run with the iOS Simulator I got build errors of the form: .../Source/JavaScriptCore/API/tests/testapi.mm:158:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls] } In particular, Clang is complaining that we're missing a call to [super dealloc] in [-TextXYZ dealloc] and [EvilAllocationObject dealloc]: <http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/API/tests/testapi.mm?rev=159351#L172> <http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/API/tests/testapi.mm?rev=159351#L440>
Created attachment 218314 [details] Patch
Comment on attachment 218314 [details] Patch r=me
Comment on attachment 218314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218314&action=review > Source/JavaScriptCore/ChangeLog:10 > + (-[EvilAllocationObject dealloc]): Add call to [super dealloc] when building without ARC > + (say, on a 32-bit Mac using Objective-C ABI < 2). What's the motivation for this change? The code in question is never compiled in 32-bit since it's wrapped in #if JSC_OBJC_API_ENABLED.
(In reply to comment #3) > (From update of attachment 218314 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218314&action=review > > > Source/JavaScriptCore/ChangeLog:10 > > + (-[EvilAllocationObject dealloc]): Add call to [super dealloc] when building without ARC > > + (say, on a 32-bit Mac using Objective-C ABI < 2). > > What's the motivation for this change? The code in question is never compiled in 32-bit since it's wrapped in #if JSC_OBJC_API_ENABLED. The added calls to [super dealloc] are unnecessary and I will remove them before landing this patch. We should also look to remove the existing !__has_feature(objc_arc)-guarded code from file Source/JavaScriptCore/API/tests/testapi.mm. Additional remarks: The change log comment about adding [super dealloc] is misleading. What I meant to write was: (-[EvilAllocationObject dealloc]): Added call to [super dealloc] when building without ARC (say, when explicitly setting CLANG_ENABLE_OBJC_ARC_i386_iphonesimulator to NO and building for iOS Simulator on a 32-bit Mac using Objective-C ABI < 2). For some reason I thought to support building without ARC for 32-bit iOS Simulator builds, including older versions of the iOS Simulator, say version < 4.0. It's unnecessary to support such older versions of iOS Simulator.
Committed r160131: <http://trac.webkit.org/changeset/160131>