Bug 125164 - ANGLE fails to build with trunk clang: unused constant kTraceBufferLen
Summary: ANGLE fails to build with trunk clang: unused constant kTraceBufferLen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-03 10:21 PST by Daniel Bates
Modified: 2013-12-03 11:28 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.40 KB, patch)
2013-12-03 10:23 PST, Daniel Bates 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-12-03 10:21:58 PST 
The constant kTraceBufferLen is only referenced in code guarded by the macro define TRACE_ENABLED. And trunk clang identifies that this constant is unused otherwise. We should only define this constant when building with TRACE_ENABLED.
Comment 1 Daniel Bates 2013-12-03 10:23:39 PST 
Created attachment 218303 [details]
Patch
Comment 2 Daniel Bates 2013-12-03 10:33:28 PST 
Filed ANGLE bug for this issue: <https://code.google.com/p/angleproject/issues/detail?id=534>.
Comment 3 Daniel Bates 2013-12-03 11:28:38 PST 
Committed r160018: <http://trac.webkit.org/changeset/160018>