Bug 125163 - [CSS Shapes] Remove explicit numbering from BasicShape::Type and CSSBasicShape::Type enums
Summary: [CSS Shapes] Remove explicit numbering from BasicShape::Type and CSSBasicShap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 98664 89256
  Show dependency tree / graph
 
Reported: 2013-12-03 10:15 PST by Zoltan Horvath
Modified: 2013-12-04 14:16 PST (History)
7 users (show)

See Also:

Attachments
proposed patch (2.78 KB, patch)
2013-12-03 10:17 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-12-03 10:15:28 PST 
I don't see any reason to have explicit numbering for the Type enum in our [CSS]BasicShape classes. I removed numbering, which will decrease the merge conflicts on Type changes.
Comment 1 Zoltan Horvath 2013-12-03 10:17:57 PST 
Created attachment 218301 [details]
proposed patch
Comment 2 Rob Buis 2013-12-04 13:41:18 PST 
Comment on attachment 218301 [details]
proposed patch

LGTM.
Comment 3 WebKit Commit Bot 2013-12-04 14:16:03 PST 
Comment on attachment 218301 [details]
proposed patch

Clearing flags on attachment: 218301

Committed r160126: <http://trac.webkit.org/changeset/160126>
Comment 4 WebKit Commit Bot 2013-12-04 14:16:05 PST 
All reviewed patches have been landed.  Closing bug.