Bug 125146 - ASSERTION FAILED: !value || (value->isPrimitiveValue()) in WebCore::StyleProperties::getLayeredShorthandValue.
Summary: ASSERTION FAILED: !value || (value->isPrimitiveValue()) in WebCore::StyleProp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
: 122457 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-03 03:51 PST by László Langó
Modified: 2014-04-19 10:14 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.06 KB, patch)
2013-12-03 03:59 PST, László Langó
no flags Details | Formatted Diff | Diff
Patch (4.35 KB, patch)
2013-12-03 06:09 PST, László Langó
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description László Langó 2013-12-03 03:51:29 PST
STDERR: ASSERTION FAILED: !value || (value->isPrimitiveValue())
STDERR: /home/lango/Webkit/Webkit/Source/WebCore/css/CSSPrimitiveValue.h(396) : WebCore::CSSPrimitiveValue* WebCore::toCSSPrimitiveValue(WebCore::CSSValue*)
STDERR: 1   0x7fdee4269376 WTFCrashWithSecurityImplication
STDERR: 2   0x7fdedf568648 WebCore::toCSSPrimitiveValue(WebCore::CSSValue*)
STDERR: 3   0x7fdedf6bf139 WebCore::StyleProperties::getLayeredShorthandValue(WebCore::StylePropertyShorthand const&) const
STDERR: 4   0x7fdedf6bdbc8 WebCore::StyleProperties::getPropertyValue(WebCore::CSSPropertyID) const
STDERR: 5   0x7fdedf6c10bc WebCore::StyleProperties::asText() const
STDERR: 6   0x7fdedf69ebcc WebCore::PropertySetCSSStyleDeclaration::cssText() const
STDERR: 7   0x7fdee052dbe7 WebCore::jsCSSStyleDeclarationCssText(JSC::ExecState*, JSC::JSValue, JSC::PropertyName)
STDERR: 8   0x50cee5 JSC::PropertySlot::getValue(JSC::ExecState*, JSC::PropertyName) const
STDERR: 9   0x7fdee3f23577 JSC::JSValue::get(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&) const
STDERR: 10  0x7fdee425b347
STDERR: 11  0x7fdee4265dfe
Comment 1 László Langó 2013-12-03 03:59:54 PST
Created attachment 218285 [details]
Patch
Comment 2 László Langó 2013-12-03 06:09:42 PST
Created attachment 218291 [details]
Patch
Comment 3 Darin Adler 2013-12-03 08:59:24 PST
Comment on attachment 218291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218291&action=review

> LayoutTests/fast/css/webkit-mask-crash-implicit-expected.txt:3
> +FAIL document.styleSheets[1].rules[0].style.cssText should be -webkit-mask-repeat: repeat-x; -webkit-mask-repeat-y: inherit;. Was -webkit-mask: inherit;.
> +FAIL document.styleSheets[1].rules[0].style.getPropertyValue('-webkit-mask') should be . Was inherit.
> +FAIL document.styleSheets[1].rules[0].style.getPropertyValue('-webkit-mask-repeat') should be repeat inherit. Was inherit.

Why is FAIL, FAIL, FAIL expected? Is this another bug? Why not expect the values we actually expect?
Comment 4 WebKit Commit Bot 2013-12-03 09:26:33 PST
Comment on attachment 218291 [details]
Patch

Clearing flags on attachment: 218291

Committed r160010: <http://trac.webkit.org/changeset/160010>
Comment 5 WebKit Commit Bot 2013-12-03 09:26:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2014-04-19 10:14:52 PDT
*** Bug 122457 has been marked as a duplicate of this bug. ***