Bug 125139 - [Mac] Modernize the WebKit API headers
Summary: [Mac] Modernize the WebKit API headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-12-03 01:40 PST by Mark Rowe (bdash)
Modified: 2013-12-11 01:24 PST (History)
1 user (show)

See Also:


Attachments
Patch (80.73 KB, patch)
2013-12-03 01:43 PST, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff
Patch (80.74 KB, patch)
2013-12-03 01:49 PST, Mark Rowe (bdash)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2013-12-03 01:40:54 PST
The WebKit API headers some legacy constructs that could be modernized while preserving binary compatibility. We should do that!

<rdar://problem/15540175>
Comment 1 Mark Rowe (bdash) 2013-12-03 01:43:04 PST
Created attachment 218276 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-03 01:44:39 PST
Attachment 218276 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/DOM/WebDOMOperations.h', u'Source/WebKit/mac/History/WebBackForwardList.h', u'Source/WebKit/mac/History/WebHistory.h', u'Source/WebKit/mac/History/WebHistoryItem.h', u'Source/WebKit/mac/History/WebHistoryItem.mm', u'Source/WebKit/mac/Plugins/WebPlugin.h', u'Source/WebKit/mac/Plugins/WebPluginContainer.h', u'Source/WebKit/mac/WebView/WebArchive.h', u'Source/WebKit/mac/WebView/WebArchive.mm', u'Source/WebKit/mac/WebView/WebDataSource.h', u'Source/WebKit/mac/WebView/WebDataSource.mm', u'Source/WebKit/mac/WebView/WebEditingDelegate.h', u'Source/WebKit/mac/WebView/WebFrame.h', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.h', u'Source/WebKit/mac/WebView/WebPolicyDelegate.h', u'Source/WebKit/mac/WebView/WebPreferences.h', u'Source/WebKit/mac/WebView/WebPreferences.mm', u'Source/WebKit/mac/WebView/WebResource.h', u'Source/WebKit/mac/WebView/WebResource.mm', u'Source/WebKit/mac/WebView/WebUIDelegate.h', u'Source/WebKit/mac/WebView/WebView.h', u'Source/WebKit/mac/WebView/WebView.mm', u'Tools/ChangeLog', u'Tools/DumpRenderTree/mac/TestRunnerMac.mm']" exit_code: 1
ERROR: Source/WebKit/mac/WebView/WebPreferences.h:170:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebPreferences.h:175:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebPreferences.h:185:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebView.h:436:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebView.h:569:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebView.h:572:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebDataSource.h:117:  Missing spaces around =  [whitespace/operators] [4]
Total errors found: 7 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Rowe (bdash) 2013-12-03 01:49:33 PST
Created attachment 218277 [details]
Patch
Comment 4 Mark Rowe (bdash) 2013-12-03 01:50:00 PST
The revised patch fixes a mistaken use of NS_ENUM when NS_OPTIONS is more appropriate.
Comment 5 WebKit Commit Bot 2013-12-03 01:51:25 PST
Attachment 218277 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/DOM/WebDOMOperations.h', u'Source/WebKit/mac/History/WebBackForwardList.h', u'Source/WebKit/mac/History/WebHistory.h', u'Source/WebKit/mac/History/WebHistoryItem.h', u'Source/WebKit/mac/History/WebHistoryItem.mm', u'Source/WebKit/mac/Plugins/WebPlugin.h', u'Source/WebKit/mac/Plugins/WebPluginContainer.h', u'Source/WebKit/mac/WebView/WebArchive.h', u'Source/WebKit/mac/WebView/WebArchive.mm', u'Source/WebKit/mac/WebView/WebDataSource.h', u'Source/WebKit/mac/WebView/WebDataSource.mm', u'Source/WebKit/mac/WebView/WebEditingDelegate.h', u'Source/WebKit/mac/WebView/WebFrame.h', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.h', u'Source/WebKit/mac/WebView/WebPolicyDelegate.h', u'Source/WebKit/mac/WebView/WebPreferences.h', u'Source/WebKit/mac/WebView/WebPreferences.mm', u'Source/WebKit/mac/WebView/WebResource.h', u'Source/WebKit/mac/WebView/WebResource.mm', u'Source/WebKit/mac/WebView/WebUIDelegate.h', u'Source/WebKit/mac/WebView/WebView.h', u'Source/WebKit/mac/WebView/WebView.mm', u'Tools/ChangeLog', u'Tools/DumpRenderTree/mac/TestRunnerMac.mm']" exit_code: 1
ERROR: Source/WebKit/mac/WebView/WebPreferences.h:170:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebPreferences.h:175:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebPreferences.h:185:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebView.h:436:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebView.h:569:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebView.h:572:  Missing spaces around =  [whitespace/operators] [4]
ERROR: Source/WebKit/mac/WebView/WebUIDelegate.h:84:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebUIDelegate.h:102:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebDataSource.h:117:  Missing spaces around =  [whitespace/operators] [4]
Total errors found: 9 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Mark Rowe (bdash) 2013-12-11 01:24:37 PST
Committed r160414: <http://trac.webkit.org/changeset/160414>