RESOLVED FIXED 125139
[Mac] Modernize the WebKit API headers 
https://bugs.webkit.org/show_bug.cgi?id=125139
Summary [Mac] Modernize the WebKit API headers
Mark Rowe (bdash)
Reported 2013-12-03 01:40:54 PST
The WebKit API headers some legacy constructs that could be modernized while preserving binary compatibility. We should do that! <rdar://problem/15540175>
Attachments
Patch (80.73 KB, patch)
2013-12-03 01:43 PST, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
Patch (80.74 KB, patch)
2013-12-03 01:49 PST, Mark Rowe (bdash) 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2013-12-03 01:43:04 PST
Created attachment 218276 [details] Patch
WebKit Commit Bot
Comment 2 2013-12-03 01:44:39 PST
Attachment 218276 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/DOM/WebDOMOperations.h', u'Source/WebKit/mac/History/WebBackForwardList.h', u'Source/WebKit/mac/History/WebHistory.h', u'Source/WebKit/mac/History/WebHistoryItem.h', u'Source/WebKit/mac/History/WebHistoryItem.mm', u'Source/WebKit/mac/Plugins/WebPlugin.h', u'Source/WebKit/mac/Plugins/WebPluginContainer.h', u'Source/WebKit/mac/WebView/WebArchive.h', u'Source/WebKit/mac/WebView/WebArchive.mm', u'Source/WebKit/mac/WebView/WebDataSource.h', u'Source/WebKit/mac/WebView/WebDataSource.mm', u'Source/WebKit/mac/WebView/WebEditingDelegate.h', u'Source/WebKit/mac/WebView/WebFrame.h', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.h', u'Source/WebKit/mac/WebView/WebPolicyDelegate.h', u'Source/WebKit/mac/WebView/WebPreferences.h', u'Source/WebKit/mac/WebView/WebPreferences.mm', u'Source/WebKit/mac/WebView/WebResource.h', u'Source/WebKit/mac/WebView/WebResource.mm', u'Source/WebKit/mac/WebView/WebUIDelegate.h', u'Source/WebKit/mac/WebView/WebView.h', u'Source/WebKit/mac/WebView/WebView.mm', u'Tools/ChangeLog', u'Tools/DumpRenderTree/mac/TestRunnerMac.mm']" exit_code: 1 ERROR: Source/WebKit/mac/WebView/WebPreferences.h:170: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit/mac/WebView/WebPreferences.h:175: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit/mac/WebView/WebPreferences.h:185: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit/mac/WebView/WebView.h:436: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit/mac/WebView/WebView.h:569: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit/mac/WebView/WebView.h:572: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit/mac/WebView/WebDataSource.h:117: Missing spaces around = [whitespace/operators] [4] Total errors found: 7 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Rowe (bdash)
Comment 3 2013-12-03 01:49:33 PST
Created attachment 218277 [details] Patch
Mark Rowe (bdash)
Comment 4 2013-12-03 01:50:00 PST
The revised patch fixes a mistaken use of NS_ENUM when NS_OPTIONS is more appropriate.
WebKit Commit Bot
Comment 5 2013-12-03 01:51:25 PST
Attachment 218277 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/DOM/WebDOMOperations.h', u'Source/WebKit/mac/History/WebBackForwardList.h', u'Source/WebKit/mac/History/WebHistory.h', u'Source/WebKit/mac/History/WebHistoryItem.h', u'Source/WebKit/mac/History/WebHistoryItem.mm', u'Source/WebKit/mac/Plugins/WebPlugin.h', u'Source/WebKit/mac/Plugins/WebPluginContainer.h', u'Source/WebKit/mac/WebView/WebArchive.h', u'Source/WebKit/mac/WebView/WebArchive.mm', u'Source/WebKit/mac/WebView/WebDataSource.h', u'Source/WebKit/mac/WebView/WebDataSource.mm', u'Source/WebKit/mac/WebView/WebEditingDelegate.h', u'Source/WebKit/mac/WebView/WebFrame.h', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.h', u'Source/WebKit/mac/WebView/WebPolicyDelegate.h', u'Source/WebKit/mac/WebView/WebPreferences.h', u'Source/WebKit/mac/WebView/WebPreferences.mm', u'Source/WebKit/mac/WebView/WebResource.h', u'Source/WebKit/mac/WebView/WebResource.mm', u'Source/WebKit/mac/WebView/WebUIDelegate.h', u'Source/WebKit/mac/WebView/WebView.h', u'Source/WebKit/mac/WebView/WebView.mm', u'Tools/ChangeLog', u'Tools/DumpRenderTree/mac/TestRunnerMac.mm']" exit_code: 1 ERROR: Source/WebKit/mac/WebView/WebPreferences.h:170: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit/mac/WebView/WebPreferences.h:175: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit/mac/WebView/WebPreferences.h:185: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit/mac/WebView/WebView.h:436: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit/mac/WebView/WebView.h:569: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit/mac/WebView/WebView.h:572: Missing spaces around = [whitespace/operators] [4] ERROR: Source/WebKit/mac/WebView/WebUIDelegate.h:84: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit/mac/WebView/WebUIDelegate.h:102: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit/mac/WebView/WebDataSource.h:117: Missing spaces around = [whitespace/operators] [4] Total errors found: 9 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Rowe (bdash)
Comment 6 2013-12-11 01:24:37 PST
Committed r160414: <http://trac.webkit.org/changeset/160414>
Note You need to log in before you can comment on or make changes to this bug.