WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
125126
Web Inspector: save view state when reloading main resources without provisional loads
https://bugs.webkit.org/show_bug.cgi?id=125126
Summary
Web Inspector: save view state when reloading main resources without provisio...
Brian Burg
Reported
2013-12-02 17:53:03 PST
The code to restore inspector view state on page reload (in
https://webkit.org/b/122125
/) saves view state on the Frame.Event.ProvisionalLoadCommitted event, and then tries to restore it on Frame.Event.MainResourceDidChange. However, these events are not one-to-one for things that do not generate provisional loads. Instead, we should add a symmetric MainResourceWillChange event that is 1:1 with MainResourceDidChange. It needs to be called from Frame.commitProvisionalLoad() and Frame.initialize() when Frame._mainResource is being set. The order should be: MainResourceWillChange -> (maybe) ProvisionalLoadCommitted -> MainResourceDidChange. Then, the view state serialization should happen on the first event. NB. Code in FrameResourceManager.frameDidNavigate is responsible for deciding whether there is a provisional load or not.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2014-02-14 09:52:27 PST
<
rdar://problem/16070884
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug