WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125116
Remove dead extract_reference_link.py (and the reftests module)
https://bugs.webkit.org/show_bug.cgi?id=125116
Summary
Remove dead extract_reference_link.py (and the reftests module)
Tim Horton
Reported
2013-12-02 15:32:00 PST
As far as I can tell, it was added in
http://trac.webkit.org/changeset/94160
as a dependency of
https://bugs.webkit.org/show_bug.cgi?id=66837
but then the patch that eventually landed for that bug didn't use it? Maybe rniwa can clear up the backstory. Seems totally unused in the repo today.
Attachments
patch
(7.43 KB, patch)
2013-12-02 15:34 PST
,
Tim Horton
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2013-12-02 15:34:20 PST
Created
attachment 218229
[details]
patch
Dirk Pranke
Comment 2
2013-12-09 15:33:27 PST
It doesn't look like I ever looked at that patch or was aware of it. It certainly seems safe enough to remove. There is similar code in the webkitpy/w3c module that would be what I'd use instead today.
Tim Horton
Comment 3
2013-12-09 15:42:20 PST
Comment on
attachment 218229
[details]
patch Thanks!
Tim Horton
Comment 4
2013-12-09 15:42:56 PST
Bets on whether I'll have to delete the directory manually?
WebKit Commit Bot
Comment 5
2013-12-09 16:09:16 PST
Comment on
attachment 218229
[details]
patch Clearing flags on attachment: 218229 Committed
r160342
: <
http://trac.webkit.org/changeset/160342
>
WebKit Commit Bot
Comment 6
2013-12-09 16:09:18 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug