Bug 125116 - Remove dead extract_reference_link.py (and the reftests module)
Summary: Remove dead extract_reference_link.py (and the reftests module)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-02 15:32 PST by Tim Horton
Modified: 2013-12-09 16:09 PST (History)
5 users (show)

See Also:

Attachments
patch (7.43 KB, patch)
2013-12-02 15:34 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-12-02 15:32:00 PST 
As far as I can tell, it was added in http://trac.webkit.org/changeset/94160 as a dependency of https://bugs.webkit.org/show_bug.cgi?id=66837 but then the patch that eventually landed for that bug didn't use it?

Maybe rniwa can clear up the backstory. Seems totally unused in the repo today.
Comment 1 Tim Horton 2013-12-02 15:34:20 PST 
Created attachment 218229 [details]
patch
Comment 2 Dirk Pranke 2013-12-09 15:33:27 PST 
It doesn't look like I ever looked at that patch or was aware of it. It certainly seems safe enough to remove. There is similar code in the webkitpy/w3c module that would be what I'd use instead today.
Comment 3 Tim Horton 2013-12-09 15:42:20 PST 
Comment on attachment 218229 [details]
patch

Thanks!
Comment 4 Tim Horton 2013-12-09 15:42:56 PST 
Bets on whether I'll have to delete the directory manually?
Comment 5 WebKit Commit Bot 2013-12-09 16:09:16 PST 
Comment on attachment 218229 [details]
patch

Clearing flags on attachment: 218229

Committed r160342: <http://trac.webkit.org/changeset/160342>
Comment 6 WebKit Commit Bot 2013-12-09 16:09:18 PST 
All reviewed patches have been landed.  Closing bug.