Bug 125107 - Baseline JIT calls to CommonSlowPaths shouldn't restore the last result
Summary: Baseline JIT calls to CommonSlowPaths shouldn't restore the last result
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-02 14:54 PST by Filip Pizlo
Modified: 2013-12-02 15:15 PST (History)
7 users (show)

See Also:

Attachments
the patch (17.68 KB, patch)
2013-12-02 14:55 PST, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-12-02 14:54:52 PST 
No need to do it.
Comment 1 Filip Pizlo 2013-12-02 14:55:55 PST 
Created attachment 218219 [details]
the patch
Comment 2 Mark Hahnenberg 2013-12-02 14:58:09 PST 
Comment on attachment 218219 [details]
the patch

r=me
Comment 3 Mark Lam 2013-12-02 14:58:19 PST 
Comment on attachment 218219 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218219&action=review

> Source/JavaScriptCore/ChangeLog:7
> +        Baseline JIT calls to CommonSlowPaths shouldn't restore the last result
> +        https://bugs.webkit.org/show_bug.cgi?id=125107
> +
> +        Reviewed by NOBODY (OOPS!).
> +

Would you mind adding a comment here to provide some context about why this change is needed, and where it was causing a problem?
Comment 4 Mark Lam 2013-12-02 15:00:12 PST 
Comment on attachment 218219 [details]
the patch

Restoring the r+ by Mark H.
Comment 5 Filip Pizlo 2013-12-02 15:00:40 PST 
(In reply to comment #3)
> (From update of attachment 218219 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218219&action=review
> 
> > Source/JavaScriptCore/ChangeLog:7
> > +        Baseline JIT calls to CommonSlowPaths shouldn't restore the last result
> > +        https://bugs.webkit.org/show_bug.cgi?id=125107
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> 
> Would you mind adding a comment here to provide some context about why this change is needed, and where it was causing a problem?

It isn't causing a problem and it isn't needed.

If there is a piece of code that can be removed because that piece of code does absolutely nothing, then we remove it.  That's what this patch does.  It removes dead code.
Comment 6 Filip Pizlo 2013-12-02 15:15:26 PST 
Landed in http://trac.webkit.org/changeset/159973