Bug 125107 – Baseline JIT calls to CommonSlowPaths shouldn't restore the last result

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

No need to do it.

[Filip Pizlo]

Created attachment 218219 [details]
the patch

[Mark Hahnenberg]

Comment on attachment 218219 [details]
the patch

r=me

[Mark Lam]

Comment on attachment 218219 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218219&action=review

> Source/JavaScriptCore/ChangeLog:7
> +        Baseline JIT calls to CommonSlowPaths shouldn't restore the last result
> +        https://bugs.webkit.org/show_bug.cgi?id=125107
> +
> +        Reviewed by NOBODY (OOPS!).
> +

Would you mind adding a comment here to provide some context about why this change is needed, and where it was causing a problem?

[Mark Lam]

Comment on attachment 218219 [details]
the patch

Restoring the r+ by Mark H.

[Filip Pizlo]

(In reply to comment #3)
> (From update of attachment 218219 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218219&action=review
> 
> > Source/JavaScriptCore/ChangeLog:7
> > +        Baseline JIT calls to CommonSlowPaths shouldn't restore the last result
> > +        https://bugs.webkit.org/show_bug.cgi?id=125107
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> 
> Would you mind adding a comment here to provide some context about why this change is needed, and where it was causing a problem?

It isn't causing a problem and it isn't needed.

If there is a piece of code that can be removed because that piece of code does absolutely nothing, then we remove it.  That's what this patch does.  It removes dead code.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/159973