Bug 125085 - [WK2] Improve readability of 'generate_message_handler' function
Summary: [WK2] Improve readability of 'generate_message_handler' function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nick Diego Yamane (diegoyam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-02 11:37 PST by Nick Diego Yamane (diegoyam)
Modified: 2013-12-02 15:01 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.65 KB, patch)
2013-12-02 11:39 PST, Nick Diego Yamane (diegoyam) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Diego Yamane (diegoyam) 2013-12-02 11:37:15 PST 
[WK2] Improve readability of 'generate_message_handler' function
Comment 1 Nick Diego Yamane (diegoyam) 2013-12-02 11:39:12 PST 
Created attachment 218201 [details]
Patch
Comment 2 Nick Diego Yamane (diegoyam) 2013-12-02 13:09:53 PST 
'generate_message_handler' function uses a local dictionary to store "conditions" for the header files that should be included in the message handler generated cpp file. When trying to understand that code, I've had some difficult to understand what that variable was storing or why it is called 'headers' when in fact it stores "conditions" for each "header". So in this patch I propose a better name for that variable and for the variable used to iterate through its keys.
Comment 3 WebKit Commit Bot 2013-12-02 15:01:06 PST 
Comment on attachment 218201 [details]
Patch

Clearing flags on attachment: 218201

Committed r159972: <http://trac.webkit.org/changeset/159972>
Comment 4 WebKit Commit Bot 2013-12-02 15:01:09 PST 
All reviewed patches have been landed.  Closing bug.