RESOLVED FIXED 125085
[WK2] Improve readability of 'generate_message_handler' function 
https://bugs.webkit.org/show_bug.cgi?id=125085
Summary [WK2] Improve readability of 'generate_message_handler' function
Nick Diego Yamane (diegoyam)
Reported 2013-12-02 11:37:15 PST
[WK2] Improve readability of 'generate_message_handler' function
Attachments
Patch (4.65 KB, patch)
2013-12-02 11:39 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nick Diego Yamane (diegoyam)
Comment 1 2013-12-02 11:39:12 PST
Created attachment 218201 [details] Patch
Nick Diego Yamane (diegoyam)
Comment 2 2013-12-02 13:09:53 PST
'generate_message_handler' function uses a local dictionary to store "conditions" for the header files that should be included in the message handler generated cpp file. When trying to understand that code, I've had some difficult to understand what that variable was storing or why it is called 'headers' when in fact it stores "conditions" for each "header". So in this patch I propose a better name for that variable and for the variable used to iterate through its keys.
WebKit Commit Bot
Comment 3 2013-12-02 15:01:06 PST
Comment on attachment 218201 [details] Patch Clearing flags on attachment: 218201 Committed r159972: <http://trac.webkit.org/changeset/159972>
WebKit Commit Bot
Comment 4 2013-12-02 15:01:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.