Bug 125077 - simplify MediaPlayerPrivateGStreamerBase::createVideoSink()
Summary: simplify MediaPlayerPrivateGStreamerBase::createVideoSink()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Víctor M. Jáquez L.
Depends on:
Reported: 2013-12-02 08:56 PST by Víctor M. Jáquez L.
Modified: 2013-12-02 11:52 PST (History)
8 users (show)

See Also:

Patch (6.16 KB, patch)
2013-12-02 09:02 PST, Víctor M. Jáquez L.
no flags Details | Formatted Diff | Diff
Patch (7.72 KB, patch)
2013-12-02 10:36 PST, Víctor M. Jáquez L.
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Víctor M. Jáquez L. 2013-12-02 08:56:06 PST
* Remove the unused parameter
* Remove the GStreamer 0.10.22 run-time validation, since we are using GStreamer 1.0 officially.
* Remove the creation of a spurious Bin for the video sink, since either the fpssink or the webkitsink are valid elements.
Comment 1 Víctor M. Jáquez L. 2013-12-02 09:02:39 PST
Created attachment 218176 [details]
Comment 2 Philippe Normand 2013-12-02 09:06:39 PST
Comment on attachment 218176 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=218176&action=review

Noice clean-up!

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:495
> +        m_videoSinkBin = m_webkitVideoSink;

Perhaps this member can be renamed and/or dropped?
Comment 3 Víctor M. Jáquez L. 2013-12-02 10:36:41 PST
Created attachment 218184 [details]
Comment 4 WebKit Commit Bot 2013-12-02 11:52:47 PST
Comment on attachment 218184 [details]

Clearing flags on attachment: 218184

Committed r159945: <http://trac.webkit.org/changeset/159945>
Comment 5 WebKit Commit Bot 2013-12-02 11:52:49 PST
All reviewed patches have been landed.  Closing bug.