RESOLVED FIXED 125077
simplify MediaPlayerPrivateGStreamerBase::createVideoSink() 
https://bugs.webkit.org/show_bug.cgi?id=125077
Summary simplify MediaPlayerPrivateGStreamerBase::createVideoSink()
Víctor M. Jáquez L.
Reported 2013-12-02 08:56:06 PST
* Remove the unused parameter * Remove the GStreamer 0.10.22 run-time validation, since we are using GStreamer 1.0 officially. * Remove the creation of a spurious Bin for the video sink, since either the fpssink or the webkitsink are valid elements.
Attachments
Patch (6.16 KB, patch)
2013-12-02 09:02 PST, Víctor M. Jáquez L. 		no flags
DetailsFormatted DiffDiff
Patch (7.72 KB, patch)
2013-12-02 10:36 PST, Víctor M. Jáquez L. 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Víctor M. Jáquez L.
Comment 1 2013-12-02 09:02:39 PST
Created attachment 218176 [details] Patch
Philippe Normand
Comment 2 2013-12-02 09:06:39 PST
Comment on attachment 218176 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218176&action=review Noice clean-up! > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:495 > + m_videoSinkBin = m_webkitVideoSink; Perhaps this member can be renamed and/or dropped?
Víctor M. Jáquez L.
Comment 3 2013-12-02 10:36:41 PST
Created attachment 218184 [details] Patch
WebKit Commit Bot
Comment 4 2013-12-02 11:52:47 PST
Comment on attachment 218184 [details] Patch Clearing flags on attachment: 218184 Committed r159945: <http://trac.webkit.org/changeset/159945>
WebKit Commit Bot
Comment 5 2013-12-02 11:52:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.