RESOLVED FIXED 125075
[JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros 
https://bugs.webkit.org/show_bug.cgi?id=125075
Summary [JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros
Nick Diego Yamane (diegoyam)
Reported 2013-12-02 05:45:04 PST
[JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros
Attachments
Patch (5.63 KB, patch)
2013-12-02 05:52 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Patch (5.63 KB, patch)
2013-12-02 09:25 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.64 KB, patch)
2013-12-02 09:33 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nick Diego Yamane (diegoyam)
Comment 1 2013-12-02 05:52:00 PST
Created attachment 218164 [details] Patch
Michael Saboff
Comment 2 2013-12-02 08:53:01 PST
Comment on attachment 218164 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218164&action=review > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:145 > +#define LLINT_CALL_THROW(exec, exceptionToThrow) do { \ Please fix the whitespace so the '\' lines up with the subsequent lines. > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:157 > +#define LLINT_CALL_RETURN(exec, callTarget) do { \ Same whitespace issue here.
Nick Diego Yamane (diegoyam)
Comment 3 2013-12-02 09:25:11 PST
Created attachment 218177 [details] Patch Fixing '\' indentation as requested by Michael.
Nick Diego Yamane (diegoyam)
Comment 4 2013-12-02 09:33:51 PST
Created attachment 218180 [details] Patch for landing
WebKit Commit Bot
Comment 5 2013-12-02 10:20:59 PST
Comment on attachment 218180 [details] Patch for landing Clearing flags on attachment: 218180 Committed r159940: <http://trac.webkit.org/changeset/159940>
WebKit Commit Bot
Comment 6 2013-12-02 10:21:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.