Bug 125075 - [JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros
Summary: [JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nick Diego Yamane (diegoyam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-02 05:45 PST by Nick Diego Yamane (diegoyam)
Modified: 2013-12-02 10:21 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.63 KB, patch)
2013-12-02 05:52 PST, Nick Diego Yamane (diegoyam) 		no flags Details | Formatted Diff | Diff
Patch (5.63 KB, patch)
2013-12-02 09:25 PST, Nick Diego Yamane (diegoyam) 		no flags Details | Formatted Diff | Diff
Patch for landing (5.64 KB, patch)
2013-12-02 09:33 PST, Nick Diego Yamane (diegoyam) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Diego Yamane (diegoyam) 2013-12-02 05:45:04 PST 
[JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros
Comment 1 Nick Diego Yamane (diegoyam) 2013-12-02 05:52:00 PST 
Created attachment 218164 [details]
Patch
Comment 2 Michael Saboff 2013-12-02 08:53:01 PST 
Comment on attachment 218164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218164&action=review

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:145
> +#define LLINT_CALL_THROW(exec, exceptionToThrow) do {               \

Please fix the whitespace so the '\' lines up with the subsequent lines.

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:157
> +#define LLINT_CALL_RETURN(exec, callTarget) do {                    \

Same whitespace issue here.
Comment 3 Nick Diego Yamane (diegoyam) 2013-12-02 09:25:11 PST 
Created attachment 218177 [details]
Patch

Fixing '\' indentation as requested by Michael.
Comment 4 Nick Diego Yamane (diegoyam) 2013-12-02 09:33:51 PST 
Created attachment 218180 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2013-12-02 10:20:59 PST 
Comment on attachment 218180 [details]
Patch for landing

Clearing flags on attachment: 218180

Committed r159940: <http://trac.webkit.org/changeset/159940>
Comment 6 WebKit Commit Bot 2013-12-02 10:21:01 PST 
All reviewed patches have been landed.  Closing bug.