Bug 125074 – [GTK] Fails to build with freetype 2.5.1

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alberto Garcia]

FreeType 2.5.1 changed the header file layout:

   http://sourceforge.net/projects/freetype/files/freetype2/2.5.1/

Now all headers went from /usr/include/freetype2/freetype/ to /usr/include/freetype2/.

At least HarfBuzzFaceCairo.cpp looks for the headers in the old path
so it doesn't build.

This is apparently not the official way to include FreeType, as
explained in the link above:

  "Applications that use [...] the documented way for header inclusion
   [...] don't need any change to the source code."

[Andres Gomez Garcia]

Giving it a look ...

[Zan Dobersek]

The GTK port relies on pkg-config to provide the correct inclusion directory, so I'm interested where this goes wrong.

[Alberto Garcia]

(In reply to comment #2)
> The GTK port relies on pkg-config to provide the correct inclusion
> directory, so I'm interested where this goes wrong.

Apparently we're including the freetype headers in an unsupported
way. We should use FT_FREETYPE_H, FT_TRUETYPE_TABLES_H, etc.

I think Andrés is testing the changes and will upload a patch soon.

[Andres Gomez Garcia]

Confirmed after upgrading freetype6 jhbuild module to 2.5.1 and trying to build:

  CXX    Source/WebCore/platform/graphics/freetype/libPlatform_la-SimpleFontDataFreeType.lo
../../Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:47:31: fatal error: freetype/tttables.h: No such file or directory
compilation terminated.
make[1]: *** [Source/WebCore/platform/graphics/freetype/libPlatform_la-SimpleFontDataFreeType.lo] Error 1
make[1]: Leaving directory `/opt/webkit/WebKit.git/WebKitBuild/Release'
make: *** [all] Error 2

[Andres Gomez Garcia]

Created attachment 218175 [details]
Patch

[Alberto Garcia]

(In reply to comment #5)
> Created an attachment (id=218175) [details]
> Patch

lgtm

[Carlos Garcia Campos]

Comment on attachment 218175 [details]
Patch

I guess this affects the stable branch too.

[Andres Gomez Garcia]

(In reply to comment #7)
> (From update of attachment 218175 [details])
> I guess this affects the stable branch too.

Yes, I think it makes sense to cherry-pick it.

[Alberto Garcia]

(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 218175 [details] [details])
> > I guess this affects the stable branch too.
> 
> Yes, I think it makes sense to cherry-pick it.

It does, I can reproduce it in Debian with freetype from sid.

[WebKit Commit Bot]

Comment on attachment 218175 [details]
Patch

Clearing flags on attachment: 218175

Committed r159939: <http://trac.webkit.org/changeset/159939>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.