Bug 125063 - Guard JIT include.
Summary: Guard JIT include.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-02 00:35 PST by László Langó
Modified: 2013-12-03 07:50 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.13 KB, patch)
2013-12-02 00:39 PST, László Langó
no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2013-12-03 05:07 PST, László Langó
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description László Langó 2013-12-02 00:35:18 PST
JSInterfaceJIT.h is unused in LLIntThunks.cpp when webkit is built without JIT.
Comment 1 László Langó 2013-12-02 00:39:46 PST
Created attachment 218147 [details]
Patch
Comment 2 Michael Saboff 2013-12-02 08:27:50 PST
Comment on attachment 218147 [details]
Patch

The whole purpose of this file is to JIT generate small thunks to jump to LLInt entry points.
Comment 3 Filip Pizlo 2013-12-02 09:10:08 PST
(In reply to comment #2)
> (From update of attachment 218147 [details])
> The whole purpose of this file is to JIT generate small thunks to jump to LLInt entry points.

Does that make Lashlo's change wrong?  I think that this change is technically correct but just leads to code that is more complicated than it needs to be.

I think that the problem here is that:

- We have separate ENABLE(JIT) and ENABLE(LLINT_C_LOOP) defines, even though the two are exactly mutually exclusive if ENABLE(LLINT).

- This entire file should basically either be guarded with either ENABLE(LLINT) && ENABLE(JIT) or ENABLE(LLINT) && !ENALBE(LLINT_C_LOOP).

Lashlo's change sort of accomplishes this, but it does so piecemeal - the whole file is guarded by ENABLE(LLINT), then an include is guarded by ENABLE(JIT), and the rest of the file is guarded by !ENABLE(LLINT_C_LOOP).
Comment 4 László Langó 2013-12-03 05:07:20 PST
Created attachment 218287 [details]
Patch
Comment 5 WebKit Commit Bot 2013-12-03 07:50:43 PST
Comment on attachment 218287 [details]
Patch

Clearing flags on attachment: 218287

Committed r160003: <http://trac.webkit.org/changeset/160003>
Comment 6 WebKit Commit Bot 2013-12-03 07:50:45 PST
All reviewed patches have been landed.  Closing bug.