JSInterfaceJIT.h is unused in LLIntThunks.cpp when webkit is built without JIT.
Created attachment 218147 [details]
Comment on attachment 218147 [details]
The whole purpose of this file is to JIT generate small thunks to jump to LLInt entry points.
(In reply to comment #2)
> (From update of attachment 218147 [details])
> The whole purpose of this file is to JIT generate small thunks to jump to LLInt entry points.
Does that make Lashlo's change wrong? I think that this change is technically correct but just leads to code that is more complicated than it needs to be.
I think that the problem here is that:
- We have separate ENABLE(JIT) and ENABLE(LLINT_C_LOOP) defines, even though the two are exactly mutually exclusive if ENABLE(LLINT).
- This entire file should basically either be guarded with either ENABLE(LLINT) && ENABLE(JIT) or ENABLE(LLINT) && !ENALBE(LLINT_C_LOOP).
Lashlo's change sort of accomplishes this, but it does so piecemeal - the whole file is guarded by ENABLE(LLINT), then an include is guarded by ENABLE(JIT), and the rest of the file is guarded by !ENABLE(LLINT_C_LOOP).
Created attachment 218287 [details]
Comment on attachment 218287 [details]
Clearing flags on attachment: 218287
Committed r160003: <http://trac.webkit.org/changeset/160003>
All reviewed patches have been landed. Closing bug.