Bug 125051 - [Cocoa] The PageLoadState::Observer is not being set on iOS
Summary: [Cocoa] The PageLoadState::Observer is not being set on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-01 17:47 PST by Sam Weinig
Modified: 2013-12-01 17:50 PST (History)
0 users

See Also:


Attachments
Patch (1.50 KB, patch)
2013-12-01 17:48 PST, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-12-01 17:47:25 PST
[Cocoa] The PageLoadState::Observer is not being set on iOS
Comment 1 Sam Weinig 2013-12-01 17:48:11 PST
Created attachment 218126 [details]
Patch
Comment 2 mitz 2013-12-01 17:49:20 PST
Comment on attachment 218126 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218126&action=review

> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:43
> +#if WK_API_ENABLED

Not sure we need these conditionals in iOS-only files.
Comment 3 Sam Weinig 2013-12-01 17:50:36 PST
(In reply to comment #2)
> (From update of attachment 218126 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218126&action=review
> 
> > Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:43
> > +#if WK_API_ENABLED
> 
> Not sure we need these conditionals in iOS-only files.

I'm going to keep it for consistency for now.
Comment 4 Sam Weinig 2013-12-01 17:50:51 PST
Committed r159906: <http://trac.webkit.org/changeset/159906>