WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
125051
[Cocoa] The PageLoadState::Observer is not being set on iOS
https://bugs.webkit.org/show_bug.cgi?id=125051
Summary
[Cocoa] The PageLoadState::Observer is not being set on iOS
Sam Weinig
Reported
2013-12-01 17:47:25 PST
[Cocoa] The PageLoadState::Observer is not being set on iOS
Attachments
Patch
(1.50 KB, patch)
2013-12-01 17:48 PST
,
Sam Weinig
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2013-12-01 17:48:11 PST
Created
attachment 218126
[details]
Patch
mitz
Comment 2
2013-12-01 17:49:20 PST
Comment on
attachment 218126
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=218126&action=review
> Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:43 > +#if WK_API_ENABLED
Not sure we need these conditionals in iOS-only files.
Sam Weinig
Comment 3
2013-12-01 17:50:36 PST
(In reply to
comment #2
)
> (From update of
attachment 218126
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=218126&action=review
> > > Source/WebKit2/UIProcess/ios/WebPageProxyIOS.mm:43 > > +#if WK_API_ENABLED > > Not sure we need these conditionals in iOS-only files.
I'm going to keep it for consistency for now.
Sam Weinig
Comment 4
2013-12-01 17:50:51 PST
Committed
r159906
: <
http://trac.webkit.org/changeset/159906
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug