Bug 125033 - [EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded
Summary: [EFL][CoordinatedGraphics] Clear m_contentsSize when new contents are loaded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-30 16:08 PST by Ryuan Choi
Modified: 2013-12-01 15:41 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.71 KB, patch)
2013-11-30 16:11 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-11-30 16:08:16 PST 
m_contentsSize should be cleared when new contents are loaded so that PageViewportController takes care of newly loaded contents having same size with previous one.
It's because PageViewportController is cleared not to make wrong behaviour while loading when new contents are committed.
Comment 1 Ryuan Choi 2013-11-30 16:11:15 PST 
Created attachment 218094 [details]
Patch
Comment 2 Gyuyoung Kim 2013-12-01 01:06:03 PST 
Comment on attachment 218094 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218094&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:992
> +    ewk_view_html_string_load(webView(), contentsSizeHTMLPortrait, 0, 0);

Assuming that m_contentsSize needs to be initialized, this test looks make sense.

> Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:374
> +    m_contentsSize = IntSize();

Noam, could you take a look this ?
Comment 3 Noam Rosenthal 2013-12-01 02:07:13 PST 
Comment on attachment 218094 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218094&action=review

Some language nits, otherwise ok with me

> Source/WebKit2/ChangeLog:9
> +        takes care of newly loaded contents having same size with previous one.

takes care -> would take care
having -> with
with -> as

>> Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:374
>> +    m_contentsSize = IntSize();
> 
> Noam, could you take a look this ?

I think this is fine.
Comment 4 Noam Rosenthal 2013-12-01 02:07:14 PST 
Comment on attachment 218094 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218094&action=review

Some language nits, otherwise ok with me

> Source/WebKit2/ChangeLog:9
> +        takes care of newly loaded contents having same size with previous one.

takes care -> would take care
having -> with
with -> as

>> Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:374
>> +    m_contentsSize = IntSize();
> 
> Noam, could you take a look this ?

I think this is fine.
Comment 5 Gyuyoung Kim 2013-12-01 05:09:12 PST 
Comment on attachment 218094 [details]
Patch

Please land this patch after fixing things Noam points out.
Comment 6 Ryuan Choi 2013-12-01 15:40:24 PST 
Committed r159901: <http://trac.webkit.org/changeset/159901>
Comment 7 Ryuan Choi 2013-12-01 15:41:02 PST 
(In reply to comment #5)
> (From update of attachment 218094 [details])
> Please land this patch after fixing things Noam points out.

landed after fixed Noam's comment.
Thanks.