Bug 125025 - Finally remove those DFG_ENABLE things
Summary: Finally remove those DFG_ENABLE things
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Reported: 2013-11-29 20:59 PST by Filip Pizlo
Modified: 2013-11-30 09:21 PST (History)
11 users (show)

See Also:

the patch (69.08 KB, patch)
2013-11-29 21:03 PST, Filip Pizlo
sam: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (69.67 KB, patch)
2013-11-29 21:53 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-11-29 20:59:23 PST
Using C preprocessor macros to control the internal debugging functionality of a compiler is insane.  It means that the debug support isn't tested all the time, it isn't even built all the time, and it makes it challenging to read the code because of a bunch of #if's littered in the most complex places (after all it's the most complex algorithms that need debug prints).

We now have Options::verboseCompilation and friends, which doesn't suffer as many of those problems.

We should get rid of the old DFG_ENABLE preprocessor flags, because this will cleanse the codebase of the insanity and it will guide would-be DFG hackers towards the right way of getting debug dumps (i.e. the commandline options).
Comment 1 Filip Pizlo 2013-11-29 21:03:19 PST
Created attachment 218085 [details]
the patch
Comment 2 Sam Weinig 2013-11-29 21:13:57 PST
Comment 3 EFL EWS Bot 2013-11-29 21:30:58 PST
Comment on attachment 218085 [details]
the patch

Attachment 218085 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/39978148
Comment 4 Build Bot 2013-11-29 21:37:20 PST
Comment on attachment 218085 [details]
the patch

Attachment 218085 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/39918130
Comment 5 Filip Pizlo 2013-11-29 21:46:35 PST
The build fails are because I forgot to give this release build love; the fixes are all trivial.
Comment 6 Filip Pizlo 2013-11-29 21:53:02 PST
Created attachment 218087 [details]
patch for landing

This one should work.
Comment 7 Filip Pizlo 2013-11-30 09:21:05 PST
Landed in http://trac.webkit.org/changeset/159886