Bug 125022 - [Cocoa] Make WKBrowsingContextController work with WKObject wrapping
Summary: [Cocoa] Make WKBrowsingContextController work with WKObject wrapping
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-29 16:01 PST by Sam Weinig
Modified: 2013-11-29 16:24 PST (History)
0 users

See Also:

Attachments
Patch (23.08 KB, patch)
2013-11-29 16:10 PST, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-11-29 16:01:53 PST 
[Cocoa] Make WKBrowsingContextController work with WKObject wrapping
Comment 1 Sam Weinig 2013-11-29 16:10:40 PST 
Created attachment 218081 [details]
Patch
Comment 2 mitz 2013-11-29 16:22:53 PST 
Comment on attachment 218081 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218081&action=review

> Source/WebKit2/ChangeLog:25
> +        Lazily setup the load and policy clients only once a delegate has been set to allow

s/setup/set up/

> Source/WebKit2/ChangeLog:35
> +        Add wrapper() helper and declare conformance to the WKObject protocol. Remove no longer used
> +        _initWithPageRef: and _browsingContextControllerForPageRef: helpers.

Exciting!

> Source/WebKit2/ChangeLog:47
> +        Stop caching the WKBrowsingContextController, as it no long makes sense since it is the same object
> +        as the WebPageProxy.

Everything is falling into place!

> Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm:614
> +- (void)_finishInitialization

Not part of the protocol so maybe reorder it out of this section.

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:51
> +#import "WKBrowsingContextControllerInternal.h"

This should go before the < imports.
Comment 3 Sam Weinig 2013-11-29 16:24:54 PST 
Committed r159877: <http://trac.webkit.org/changeset/159877>