Bug 125021 - [MediaStream] Use iterator-based loops instead of index-based loops
Summary: [MediaStream] Use iterator-based loops instead of index-based loops
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-29 15:40 PST by Roger Zanoni
Modified: 2013-12-02 13:38 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.87 KB, patch)
2013-11-29 15:41 PST, Roger Zanoni
no flags Details | Formatted Diff | Diff
Patch (4.61 KB, patch)
2013-12-02 11:16 PST, Roger Zanoni
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Zanoni 2013-11-29 15:40:24 PST
Changing some index based loops to iterator loops and using auto keyword instead of default iterators
Comment 1 Roger Zanoni 2013-11-29 15:41:40 PST
Created attachment 218080 [details]
Patch
Comment 2 Sam Weinig 2013-11-29 16:22:39 PST
Comment on attachment 218080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218080&action=review

A few notes:
- This bug does not have a descriptive enough title.
- The patch is missing a changelog.

> Source/WebCore/Modules/mediastream/MediaStream.cpp:140
> +    for (auto iter = source.begin(); iter != source.end(); ++iter)

The normal pattern we use is:

for (auto it = source.begin(), end = source.end(); it != end; ++it)
    ...

This avoids resolving .end() multiple times.

> Source/WebCore/Modules/mediastream/MediaStream.cpp:-259
> +    for (auto iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter)
> +        if (!(*iter)->ended())
>              return;
> -    
> -    for (size_t i = 0; i < m_videoTracks.size(); ++i)
> -        if (!m_videoTracks[i]->ended())
> +    for (auto iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter)
> +        if (!(*iter)->ended())
>              return;
> -    

The two loops should have braces.
Comment 3 Roger Zanoni 2013-12-02 11:16:46 PST
Created attachment 218193 [details]
Patch
Comment 4 WebKit Commit Bot 2013-12-02 13:38:31 PST
Comment on attachment 218193 [details]
Patch

Clearing flags on attachment: 218193

Committed r159958: <http://trac.webkit.org/changeset/159958>
Comment 5 WebKit Commit Bot 2013-12-02 13:38:34 PST
All reviewed patches have been landed.  Closing bug.