Bug 125021 – [MediaStream] Use iterator-based loops instead of index-based loops

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Roger Zanoni]

Changing some index based loops to iterator loops and using auto keyword instead of default iterators

[Roger Zanoni]

Created attachment 218080 [details]
Patch

[Sam Weinig]

Comment on attachment 218080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=218080&action=review

A few notes:
- This bug does not have a descriptive enough title.
- The patch is missing a changelog.

> Source/WebCore/Modules/mediastream/MediaStream.cpp:140
> +    for (auto iter = source.begin(); iter != source.end(); ++iter)

The normal pattern we use is:

for (auto it = source.begin(), end = source.end(); it != end; ++it)
    ...

This avoids resolving .end() multiple times.

> Source/WebCore/Modules/mediastream/MediaStream.cpp:-259
> +    for (auto iter = m_audioTracks.begin(); iter != m_audioTracks.end(); ++iter)
> +        if (!(*iter)->ended())
>              return;
> -    
> -    for (size_t i = 0; i < m_videoTracks.size(); ++i)
> -        if (!m_videoTracks[i]->ended())
> +    for (auto iter = m_videoTracks.begin(); iter != m_videoTracks.end(); ++iter)
> +        if (!(*iter)->ended())
>              return;
> -    

The two loops should have braces.

[Roger Zanoni]

Created attachment 218193 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 218193 [details]
Patch

Clearing flags on attachment: 218193

Committed r159958: <http://trac.webkit.org/changeset/159958>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.