Bug 125012 – Fix build warning in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tibor Mészáros]

There are some unused parameter warning in WebKit2 during building.

[Tibor Mészáros]

Created attachment 218059 [details]
Patch

fix unused parameter warnings

[Tibor Mészáros]

Created attachment 218061 [details]
Patch v2

Missed the bugzilla link from the previous patch.

[Csaba Osztrogonác]

Comment on attachment 218061 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=218061&action=review

> Source/WebKit2/Shared/API/c/WKDeprecatedFunctions.cpp:42
> +    UNUSED_PARAM(array);

You can simple remove the name of the parameter as you did it in Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1390
> +    UNUSED_PARAM(pluginSize);
> +    UNUSED_PARAM(appletElement);
> +    UNUSED_PARAM(paramNames);
> +    UNUSED_PARAM(paramValues);

URL is unused too.

[Tibor Mészáros]

Created attachment 218067 [details]
Patch v3

As you mentioned, I take these changes on previous patch.

[Csaba Osztrogonác]

(In reply to comment #3)
> URL is unused too.
Ah, it isn't a parameter name.

[Csaba Osztrogonác]

Comment on attachment 218067 [details]
Patch v3

LGTM, but it needs WK2 owner review.

[WebKit Commit Bot]

Comment on attachment 218067 [details]
Patch v3

Clearing flags on attachment: 218067

Committed r159882: <http://trac.webkit.org/changeset/159882>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.